public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Nobin Mathew <nobin.mathew@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Robert Hancock <hancockr@shaw.ca>,
	jirislaby@gmail.com
Subject: Re: sharing interrupt between PCI device
Date: Sat, 8 Nov 2008 10:27:16 -0700	[thread overview]
Message-ID: <20081108172716.GA28039@colo.lackof.org> (raw)
In-Reply-To: <8d6898730811042349p19e65556l8e1c851b27758d5@mail.gmail.com>

On Wed, Nov 05, 2008 at 01:19:29PM +0530, Nobin Mathew wrote:
> Hi
> 
> This is the system information X86_64 platform Xeon dual core processor.
> 
> I saw the pci_disable_device () it is calling pcibios_disable_device
> () and this is is defined as
> 
> void pcibios_disable_device (struct pci_dev *dev)
> {
>         pcibios_disable_resources(dev);
>         if (pcibios_disable_irq)
>                 pcibios_disable_irq(dev);
> }
> 
> In i386 platform, I could not find a definition for these calls in
> x86_64 platform, i think it is using i386 platform code.

cscope would have helped you out here.
See arch/x86/pci/acpi.c:

int __init pci_acpi_init(void)
{
...
        pcibios_enable_irq = acpi_pci_irq_enable;
        pcibios_disable_irq = acpi_pci_irq_disable;
...
}

So I see how the IRQ is enabled and disabled. I still don't see where
an interrupt handler is bound to IRQ 225 (output you posted today in
another email). Nobin, can you dump /proc/interrupts when both drivers
are loaded and also send the dmesg output after both are loaded?

The "lspci" output Jiri asked for would be very helpful too.

thanks,
grant

> 
> Thanks
> Nobin Mathew
> 
> 
> 
> 
> 
> On Wed, Nov 5, 2008 at 5:58 AM, Robert Hancock <hancockr@shaw.ca> wrote:
> > Nobin Mathew wrote:
> >>
> >> Hi,
> >>
> >> I think this question is already asked in this mailing list and Sorry
> >> for asking this again.
> >>
> >> My problem is this:
> >>
> >> I have two PCI devices ( also two kernel drivers for those) which
> >> shares the interupt. When I remove one driver other device stops
> >> working, which is happening due to pci_disable_device () in removed
> >> driver. This call is disabling the shared interrupt.
> >
> > pci_disable_device shouldn't be disabling the interrupt line, at least not
> > in this case. Without more details on the platform or drivers, it's
> > difficult to say why this would happen.
> >
> >>
> >> We can avoid this by just removing the pci_disable_device () in the
> >> driver, but i dont think this is a good way (correct me if I am
> >> wrong).
> >>
> >> Can you suggest some ways to overcome this issue.
> >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2008-11-08 17:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.h7+lofM1lpbRM5V4/ti5d7RwXuM@ifi.uio.no>
2008-11-05  0:28 ` sharing interrupt between PCI device Robert Hancock
2008-11-05  7:49   ` Nobin Mathew
2008-11-05  8:36     ` Jiri Slaby
2008-11-05  9:20       ` Nobin Mathew
2008-11-06  6:11         ` Nobin Mathew
2008-11-06  7:44           ` Nobin Mathew
2008-11-06 21:24             ` Jiri Slaby
2008-11-07  5:46               ` Nobin Mathew
2008-11-08  7:57         ` Grant Grundler
2008-11-08  9:49           ` Jiri Slaby
2008-11-08 11:53             ` Nobin Mathew
2008-11-08 11:57               ` Jiri Slaby
2008-11-08 17:27     ` Grant Grundler [this message]
2008-11-08 19:10       ` Jiri Slaby
2008-11-08 19:15         ` Grant Grundler
2008-11-10  6:35           ` Nobin Mathew
2008-11-10  6:39             ` Nobin Mathew
2008-11-10  6:47               ` Nobin Mathew
2008-11-10  7:51             ` Grant Grundler
2008-11-10  7:58               ` Ingo Molnar
2008-11-10 10:31                 ` Nobin Mathew
2008-11-10 15:42                   ` Nobin Mathew
2008-11-10 20:34                     ` Grant Grundler
2008-11-11  4:57                       ` Nobin Mathew
2008-11-11 16:24                         ` Altobelli, David
2008-11-11 18:49                           ` Robert Hancock
2008-11-10 20:33                 ` Grant Grundler
2008-11-03 13:32 Nobin Mathew
2008-11-03 14:44 ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081108172716.GA28039@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=hancockr@shaw.ca \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nobin.mathew@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox