* [PATCH] x86: x86_32 has its own irq_regs definition
@ 2008-11-10 5:28 Harvey Harrison
2008-11-10 7:42 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-11-10 5:28 UTC (permalink / raw)
To: Ingo Molnar; +Cc: H. Peter Anvin, Thomas Gleixner, LKML
Impact: prevent second percpu define of unused irq_regs
Arches that have their own irq_regs definition are expected to
define ARCH_HAS_OWN_IRQ_REGS or else a generic (unused) set
will also be defined in lib/irq_regs.c
Sparse noticed the unused generic one had no prototype:
lib/irq_regs.c:15:1: warning: symbol 'per_cpu____irq_regs' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
arch/x86/include/asm/irq_regs_32.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/irq_regs_32.h b/arch/x86/include/asm/irq_regs_32.h
index af2f02d..86afd74 100644
--- a/arch/x86/include/asm/irq_regs_32.h
+++ b/arch/x86/include/asm/irq_regs_32.h
@@ -9,6 +9,8 @@
#include <asm/percpu.h>
+#define ARCH_HAS_OWN_IRQ_REGS
+
DECLARE_PER_CPU(struct pt_regs *, irq_regs);
static inline struct pt_regs *get_irq_regs(void)
--
1.6.0.3.866.gc189b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: x86_32 has its own irq_regs definition
2008-11-10 5:28 [PATCH] x86: x86_32 has its own irq_regs definition Harvey Harrison
@ 2008-11-10 7:42 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-10 7:42 UTC (permalink / raw)
To: Harvey Harrison; +Cc: H. Peter Anvin, Thomas Gleixner, LKML
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Impact: prevent second percpu define of unused irq_regs
>
> Arches that have their own irq_regs definition are expected to
> define ARCH_HAS_OWN_IRQ_REGS or else a generic (unused) set
> will also be defined in lib/irq_regs.c
>
> Sparse noticed the unused generic one had no prototype:
> lib/irq_regs.c:15:1: warning: symbol 'per_cpu____irq_regs' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/x86/include/asm/irq_regs_32.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
applied to tip/x86/cleanups, thanks Harvey!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-10 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-10 5:28 [PATCH] x86: x86_32 has its own irq_regs definition Harvey Harrison
2008-11-10 7:42 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox