From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC-PATCH] x86: really use __builtin_memcmp on x86_32
Date: Mon, 10 Nov 2008 08:45:37 +0100 [thread overview]
Message-ID: <20081110074536.GB2093@elte.hu> (raw)
In-Reply-To: <1226297544.5478.26.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Impact: prevent generic code from overriding __builtin_memcmp
>
> lib/string.c was using a generic implementation of memcmp
> because __HAVE_ARCH_MEMCMP was not defined and it was then doing
> #undef memcmp and defining a generic version.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/x86/include/asm/string_32.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> +#define __HAVE_ARCH_MEMCMP
> #define memcmp __builtin_memcmp
>
> #define __HAVE_ARCH_MEMCHR
on a quick look, since x86 sets __HAVE_ARCH_STRSTR, nothing in
lib/string.c would actually use this generic (and slower) memcmp
implementation, correct? So there should be no impact to object code,
it's a cleanup - right?
Ingo
next prev parent reply other threads:[~2008-11-10 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 6:12 [RFC-PATCH] x86: really use __builtin_memcmp on x86_32 Harvey Harrison
2008-11-10 7:45 ` Ingo Molnar [this message]
2008-11-10 8:05 ` Ingo Molnar
2008-11-10 16:53 ` Harvey Harrison
2008-11-10 8:38 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110074536.GB2093@elte.hu \
--to=mingo@elte.hu \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox