From: David Brownell <david-b@pacbell.net>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Andrew Morton <akpm@linux-foundation.org>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: bunch of drivers: fix 'no irq' case handing
Date: Mon, 10 Nov 2008 14:34:29 -0800 [thread overview]
Message-ID: <200811101434.29772.david-b@pacbell.net> (raw)
In-Reply-To: <20081106174111.GA21882@oksana.dev.rtsoft.ru>
On Thursday 06 November 2008, Anton Vorontsov wrote:
> This patch fixes bunch of irq checking misuses. Most drivers were getting
> irq via platform_get_irq(), which returns -ENXIO or r->start. Platforms
> may specify r->start = 0 to emphasize 'no irq' case, and drivers should
> handle this correctly.
Just strike that "Platforms may specify..." sentence. It's incorrect.
The normal way to specify "no IRQ" is, surprise!, to not specify one.
The rule about IRQ=0 is that it's not for generic driver use... and I
happen to know a family of platforms where it's used for the RTC and
a few other core system drivers. (Your patch doesn't touch them.)
> ...
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
next prev parent reply other threads:[~2008-11-10 22:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 17:41 [PATCH] rtc: bunch of drivers: fix 'no irq' case handing Anton Vorontsov
2008-11-10 22:34 ` David Brownell [this message]
2008-11-12 0:17 ` Andrew Morton
2008-11-12 10:21 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811101434.29772.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox