From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Robert Richter <robert.richter@amd.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] oprofile: re-arm APIC_DM_NMI in ppro_check_ctrs()
Date: Mon, 10 Nov 2008 16:49:48 +0100 [thread overview]
Message-ID: <20081110154948.GW29626@one.firstfloor.org> (raw)
In-Reply-To: <491843C4.9090306@cosmosbay.com>
> oprofile_add_sample(regs, i);
> + /*
> + * We need to unmask the apic vector *before*
> + * writing reset_value to msr counter
> + */
> + apic_write(APIC_LVTPC, APIC_DM_NMI);
> wrmsrl(msrs->counters[i].addr, -reset_value[i]);
> }
> }
>
> - /* Only P6 based Pentium M need to re-unmask the apic vector but it
> - * doesn't hurt other P6 variant */
> - apic_write(APIC_LVTPC, apic_read(APIC_LVTPC) & ~APIC_LVT_MASKED);
Did you also test if it really needs to be inside the if () or
just before the wrmsrl?
-Andi
next prev parent reply other threads:[~2008-11-10 15:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 17:13 [git pull] OProfile fixes for v2.6.28 Robert Richter
2008-11-07 18:22 ` Ingo Molnar
2008-11-10 8:05 ` Eric Dumazet
2008-11-10 8:43 ` Andi Kleen
2008-11-10 9:01 ` Eric Dumazet
2008-11-10 14:23 ` [PATCH] oprofile: re-arm APIC_DM_NMI in ppro_check_ctrs() Eric Dumazet
2008-11-10 15:49 ` Andi Kleen [this message]
2008-11-10 15:50 ` Eric Dumazet
2008-11-10 17:46 ` Andi Kleen
2008-11-11 8:32 ` Eric Dumazet
2008-11-17 17:33 ` Robert Richter
2008-11-17 18:25 ` Andi Kleen
2008-11-18 8:57 ` Robert Richter
2008-11-10 16:11 ` Cyrill Gorcunov
2008-11-10 16:19 ` Eric Dumazet
2008-11-10 16:31 ` Cyrill Gorcunov
2008-11-17 17:57 ` [git pull] OProfile fixes for v2.6.28 Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110154948.GW29626@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox