public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: djwong@us.ibm.com, khali@linux-fr.org,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 3/5] adt7470: Check input range when sysfs files are written
Date: Mon, 10 Nov 2008 16:22:14 -0800	[thread overview]
Message-ID: <20081110162214.b8202b60.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081107185636.13022.54109.stgit@elm3a70.beaverton.ibm.com>

On Fri, 07 Nov 2008 10:56:36 -0800
"Darrick J. Wong" <djwong@us.ibm.com> wrote:

> Subject: [PATCH 3/5] adt7470: Check input range when sysfs files are written
> 
> Implement correct rounding and range checking for adt7470.
> 
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>

When writing changelogs, please explain _why_ a change was made, as
well as what the change does.

Coz I'm sitting here wondering if we need this in 2.6.28 and I don't
have all the information.

Looking at it, I guess it does change the userspace interface in minor
ways, so we should merge it into 2.6.28.  Ditto
adt7473-check-inputs-from-sysfs-writes.patch.  Agree?


  reply	other threads:[~2008-11-11  0:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 18:56 [PATCH 0/5] Various hwmon patches Darrick J. Wong
2008-11-07 18:56 ` [PATCH 1/5] adt7462: New hwmon driver Darrick J. Wong
2008-11-07 19:04   ` Harvey Harrison
2008-11-07 19:27     ` Andrew Morton
2008-11-07 19:34       ` Darrick J. Wong
2008-11-07 19:38     ` Darrick J. Wong
2008-11-07 19:18   ` Andrew Morton
2008-11-07 18:56 ` [PATCH 2/5] i5k_amb: Load automatically on all 5000/5400 chipsets Darrick J. Wong
2008-11-08 11:09   ` Jean Delvare
2008-11-11  6:26     ` Greg KH
2008-11-07 18:56 ` [PATCH 3/5] adt7470: Check input range when sysfs files are written Darrick J. Wong
2008-11-11  0:22   ` Andrew Morton [this message]
2008-11-11  0:49     ` Darrick J. Wong
2008-11-07 18:56 ` [PATCH 4/5] adt7473: Check inputs from sysfs writes Darrick J. Wong
2008-11-07 19:20   ` Andrew Morton
2008-11-07 20:35     ` Jean Delvare
2008-11-07 20:49     ` Joe Perches
2008-11-07 21:00       ` Jean Delvare
2008-11-07 21:02         ` Randy Dunlap
2008-11-07 18:56 ` [PATCH 5/5] lm85: Support adt7468 chips Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081110162214.b8202b60.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=djwong@us.ibm.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox