Re: [git pull] OProfile fixes for v2.6.28

Eric Dumazet
2008-11-10T09:01:46Z

Andi Kleen a écrit :
> Eric Dumazet <dada1@cosmosbay.com> writes:
>
>> diff --git a/arch/x86/oprofile/op_model_ppro.c b/arch/x86/oprofile/op_model_ppro.c
>> index 3f1b81a..716d26f 100644
>> --- a/arch/x86/oprofile/op_model_ppro.c
>> +++ b/arch/x86/oprofile/op_model_ppro.c
>> @@ -69,7 +69,7 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs)
>> int i;
>>
>> if (!reset_value) {
>> - reset_value = kmalloc(sizeof(unsigned) * num_counters,
>> + reset_value = kmalloc(sizeof(reset_value[0]) * num_counters,
>
> Thanks for tracking this down.
>
> But that still doesn't explain why 2.6.27 fails too?

No :(

In fact 2.6.24 fails too. Oprofile never worked correctly.

Still investigating...