public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: jkosina@suse.cz, linux-kernel@vger.kernel.org
Subject: [PATCH] Use single threaded work queue for hid_compat
Date: Mon, 10 Nov 2008 22:51:50 +0100	[thread overview]
Message-ID: <20081110215150.GA8460@basil.nowhere.org> (raw)

Use single threaded work queue for hid_compat

I doubt HID really needs to scale over multiple CPUs. So only use a
single threaded workqueue for HID_COMPAT. This avoids some excessive
thread use on systems with a larger number of CPUs.

Should still go into 2.6.28 if possible.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 drivers/hid/hid-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.28-rc4-test/drivers/hid/hid-core.c
===================================================================
--- linux-2.6.28-rc4-test.orig/drivers/hid/hid-core.c	2008-11-06 20:26:34.000000000 +0100
+++ linux-2.6.28-rc4-test/drivers/hid/hid-core.c	2008-11-10 22:36:49.000000000 +0100
@@ -1729,7 +1729,7 @@
 		goto err_bus;
 
 #ifdef CONFIG_HID_COMPAT
-	hid_compat_wq = create_workqueue("hid_compat");
+	hid_compat_wq = create_singlethread_workqueue("hid_compat");
 	if (!hid_compat_wq) {
 		hidraw_exit();
 		goto err;

             reply	other threads:[~2008-11-10 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10 21:51 Andi Kleen [this message]
2008-11-11 22:41 ` [PATCH] Use single threaded work queue for hid_compat Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081110215150.GA8460@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox