From: Greg KH <greg@kroah.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: only build the tree if we really want to
Date: Mon, 10 Nov 2008 22:15:20 -0800 [thread overview]
Message-ID: <20081111061520.GB13156@kroah.com> (raw)
In-Reply-To: <4915E91D.8080707@s5r6.in-berlin.de>
On Sat, Nov 08, 2008 at 08:31:41PM +0100, Stefan Richter wrote:
> Greg KH wrote:
> > On Sat, Nov 08, 2008 at 04:59:37PM +0100, Stefan Richter wrote:
> >>> -endif # STAGING
> >>> +endif # !STAGING_EXCLUDE_BUILD
> >> Which purpose is the STAGING kconfig variable serving after this?
> >
> > Sitting there and looking pretty :)
> >
> >> It controls the visibility of the menu, but switching it off won't
> >> switch off the staging drivers if they were previously enabled, would
> >> it?
> >
> > Try it and look in wonder :)
> >
> > If something affects the visibility of the menu for those config
> > options, it controls if those options can be enabled or not.
>
> Right. But if you had STAGING on, STAGING_EXCLUDE_BUILD off, and for
> example ET131X on, then ET131X will still be on if you switch STAGING
> off and save the configuration.
I think Linus fixed this, look at 2.6.28-rc4.
thanks,
greg k-h
next prev parent reply other threads:[~2008-11-11 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 5:45 [GIT PATCH] STAGING fixes for 2.6.28 Greg KH
2008-11-08 5:45 ` [PATCH 1/2] Staging: only build the tree if we really want to Greg KH
2008-11-08 15:59 ` Stefan Richter
2008-11-08 18:30 ` Greg KH
2008-11-08 19:31 ` Stefan Richter
2008-11-11 6:15 ` Greg KH [this message]
2008-11-08 5:45 ` [PATCH 2/2] Staging: make usbip depend on CONFIG_NET Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111061520.GB13156@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox