Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware

Nick Warne
2008-11-15T12:32:31Z

On Wed, 12 Nov 2008 16:56:50 +0000
Matthew Garrett <mjg59@srcf.ucam.org> wrote:

> Does this work?
>
> diff --git a/drivers/input/keyboard/atkbd.c
> b/drivers/input/keyboard/atkbd.c index 22016ca..15479ef 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1460,6 +1460,15 @@ static struct dmi_system_id
> atkbd_dmi_quirk_table[] __initdata = { .driver_data =
> atkbd_dell_laptop_keymap_fixup, },
> {
> + .ident = "Dell Laptop",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer
> Corporation"),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /*
> Portable */
> + },
> + .callback = atkbd_setup_fixup,
> + .driver_data = atkbd_dell_laptop_keymap_fixup,
> + },
> + {
> .ident = "HP 2133",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>

OK, as discussed, I cannot test this, but my research leads to this to
be correct:

http://ubuntuforums.org/showthread.php?t=978973

Dell use vendor ID s either 'Dell Inc.' or 'Dell Computer Corporation'
exclusively.

So I think this can be officially submitted.

Nick

--
Free Software Foundation Associate Member 5508