public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ken Chen <kenchen@google.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch] add /proc/pid/stack to dump task's stack trace
Date: Tue, 11 Nov 2008 14:20:18 +0100	[thread overview]
Message-ID: <20081111132018.GI14989@elte.hu> (raw)
In-Reply-To: <20081111122531.GA5836@joi>


* Marcin Slusarz <marcin.slusarz@gmail.com> wrote:

> On Fri, Nov 07, 2008 at 10:03:04AM +0100, Ingo Molnar wrote:
> > 
> > btw., the feature works beautifully:
> > 
> > task sleeping/blocked:
> > 
> >  # cat /proc/1/stack
> >  [<ffffffff802bfe75>] do_select+0x51a/0x582
> >  [<ffffffff802c0059>] core_sys_select+0x17c/0x218
> >  [<ffffffff802c0344>] sys_select+0x99/0xc1
> >  [<ffffffff8020c23b>] system_call_fastpath+0x16/0x1b
> >  [<ffffffffffffffff>] 0xffffffffffffffff
> > 
> > task running on this CPU:
> > 
> >  # cat /proc/self/stack
> >  [<ffffffff80216f79>] save_stack_trace_tsk+0x26/0x44
> >  [<ffffffff802f59a5>] proc_pid_stack+0x6e/0xd3
> >  [<ffffffff802f6da3>] proc_info_read+0x68/0xba
> >  [<ffffffff802b2f17>] vfs_read+0xa9/0xe3
> >  [<ffffffff802b301f>] sys_read+0x4c/0x73
> >  [<ffffffff8020c23b>] system_call_fastpath+0x16/0x1b
> >  [<ffffffffffffffff>] 0xffffffffffffffff
> > 
> > task running on another CPU in user-space:
> > 
> >  # cat /proc/18579/stack
> >  [<ffffffffffffffff>] 0xffffffffffffffff
> 
> so this file provides view of _kernel_ stack only?
> shouldn't it be named kernel-stack then?

it prints the kernel stack right now, but i'd not restrict it to the 
kernel stack conceptually: i think we could eventually expand it to 
print the user-space portion of the stack as well. (in the case when 
user-space is built with frame pointers) We've got code for that in 
the kernel already. It would be an easy one-stop-shop for full-range.

	Ingo

  parent reply	other threads:[~2008-11-11 13:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 19:01 [patch] add /proc/pid/stack to dump task's stack trace Ken Chen
2008-11-06 19:51 ` Alexey Dobriyan
2008-11-06 20:12   ` Ken Chen
2008-11-06 20:35     ` Ingo Molnar
2008-11-07  0:30       ` Ken Chen
2008-11-07  0:48         ` Alexey Dobriyan
2008-11-07  7:41           ` Ingo Molnar
2008-11-07  7:59             ` Ingo Molnar
2008-11-07  8:20               ` Alexey Dobriyan
2008-11-07  8:32                 ` Ingo Molnar
2008-11-07  8:49                   ` Alexey Dobriyan
2008-11-07  8:53                     ` Ingo Molnar
2008-11-07  9:03                       ` Ingo Molnar
2008-11-07  9:16                         ` Andrew Morton
2008-11-07  9:29                           ` Ingo Molnar
2008-11-07 17:51                             ` Alexey Dobriyan
2008-11-08 12:06                               ` Ingo Molnar
2008-11-10 23:54                             ` Andrew Morton
2008-11-11 10:00                               ` Ingo Molnar
2008-11-11 12:25                         ` Marcin Slusarz
2008-11-11 12:33                           ` Alexey Dobriyan
2008-11-11 13:20                           ` Ingo Molnar [this message]
2008-11-11 14:03                             ` Mikael Pettersson
2008-11-11 14:19                               ` Ingo Molnar
2008-11-07 18:38                   ` Ken Chen
2008-11-07 18:46                     ` Paul Menage
2008-11-08 12:10                     ` Ingo Molnar
2008-11-09 18:08                       ` Alexey Dobriyan
2008-11-10  8:41                         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081111132018.GI14989@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kenchen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox