From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Gregory Haskins <gregory.haskins@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Ingo Molnar <mingo@elte.hu>, Dipankar Sarma <dipankar@in.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
David Collier-Brown <davecb@sun.com>,
Tim Connors <tconnors@astro.swin.edu.au>,
Max Krasnyansky <maxk@qualcomm.com>
Subject: Re: [RFC PATCH v3 3/5] sched: nominate preferred wakeup cpu
Date: Tue, 11 Nov 2008 20:51:26 +0530 [thread overview]
Message-ID: <20081111152126.GF3593@linux.vnet.ibm.com> (raw)
In-Reply-To: <491991BE.9080405@gmail.com>
On Tue, Nov 11, 2008 at 09:07:58AM -0500, Gregory Haskins wrote:
> > Would it make sense to place the preferred_wakeup_cpu stuff in the
> > root_domain structure we already have?
> >
>
> From the description, this is exactly what the root-domains were created
> to solve.
>
> Vaidyanathan, just declare your object in "struct root_domain" and
> initialize it in init_rootdomain() in kernel/sched.c, and then access it
> via rq->rd to take advantage of this infrastructure. It will
> automatically follow any partitioning that happens to be configured.
If I understand correctly, we may want to have more than one preferred
cpu in a given sched domain, taking into account node topology i.e if a
given sched domain encompasses two nodes, then we may like to designate
2 preferred wakeup_cpu's, one per node. If that is the case, then
root_domain may not be of use here?
- vatsa
next prev parent reply other threads:[~2008-11-11 15:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 18:32 [RFC PATCH v3 0/5] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 1/5] sched: Framework for sched_mc/smt_power_savings=N Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 2/5] sched: favour lower logical cpu number for sched_mc balance Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 3/5] sched: nominate preferred wakeup cpu Vaidyanathan Srinivasan
2008-11-11 13:43 ` Peter Zijlstra
2008-11-11 14:07 ` Gregory Haskins
2008-11-11 15:21 ` Srivatsa Vaddagiri [this message]
2008-11-11 15:26 ` Peter Zijlstra
2008-11-11 17:15 ` Vaidyanathan Srinivasan
2008-11-11 17:17 ` Vaidyanathan Srinivasan
2008-11-11 16:48 ` Vaidyanathan Srinivasan
2008-11-11 16:49 ` Balbir Singh
2008-11-11 17:27 ` Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 4/5] sched: bias task wakeups to preferred semi-idle packages Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 5/5] sched: activate active load balancing in new idle cpus Vaidyanathan Srinivasan
2008-11-11 13:47 ` Peter Zijlstra
2008-11-11 17:04 ` Vaidyanathan Srinivasan
2008-11-11 17:21 ` Peter Zijlstra
2008-11-11 17:31 ` Vaidyanathan Srinivasan
2008-11-10 18:50 ` [RFC PATCH v3 0/5] Tunable sched_mc_power_savings=n Peter Zijlstra
2008-11-11 4:52 ` Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111152126.GF3593@linux.vnet.ibm.com \
--to=vatsa@in.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=davecb@sun.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=gregory.haskins@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tconnors@astro.swin.edu.au \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox