Re: [PATCH] rtc: bunch of drivers: fix 'no irq' case handing

Andrew Morton
2008-11-12T00:18:10Z

On Thu, 6 Nov 2008 20:41:11 +0300
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:

> This patch fixes bunch of irq checking misuses. Most drivers were getting
> irq via platform_get_irq(), which returns -ENXIO or r->start. Platforms
> may specify r->start = 0 to emphasize 'no irq' case, and drivers should
> handle this correctly.
>
> rtc-cmos.c is special. It is using PNP and platform bindings. Hopefully
> nobody is using PNP IRQ 0 for RTC. So the changes should be safe.
>
> rtc-sh.c is using platform_get_irq, but was storing a result into an
> unsigned type, then was checking for < 0. This is fixed now.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Do we see any reason why this should be pushed into 2.6.28?