[patch 14/49] md: fix bug in raid10 recovery.

Greg KH
2008-11-12T00:31:26Z

[-- Attachment #1: md-fix-bug-in-raid10-recovery.patch --]
[-- Type: text/plain, Size: 968 bytes --]

2.6.27-stable review patch. If anyone has any objections, please let us know.

------------------

From: Neil Brown <neilb@suse.de>

commit a53a6c85756339f82ff19e001e90cfba2d6299a8 upstream

Adding a spare to a raid10 doesn't cause recovery to start.
This is due to an silly type in
commit 6c2fce2ef6b4821c21b5c42c7207cb9cf8c87eda
and so is a bug in 2.6.27 and .28-rc.

Thanks to Thomas Backlund for bisecting to find this.

Cc: Thomas Backlund <tmb@mandriva.org>
Cc: George Spelvin <linux@horizon.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
drivers/md/raid10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1132,7 +1132,7 @@ static int raid10_add_disk(mddev_t *mdde
if (!enough(conf))
return -EINVAL;

- if (rdev->raid_disk)
+ if (rdev->raid_disk >= 0)
first = last = rdev->raid_disk;

if (rdev->saved_raid_disk >= 0 &&

--