public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tracing/fastboot: Use the ring-buffer timestamp for initcall entries
Date: Wed, 12 Nov 2008 10:25:48 +0100	[thread overview]
Message-ID: <20081112092548.GE4748@elte.hu> (raw)
In-Reply-To: <491A062A.8080406@gmail.com>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Impact: Split the boot tracer entries in two parts: call and return
> 
> Now that we are using the sched tracer from the boot tracer, we want 
> to use the same timestamp than the ring-buffer to have consistent 
> time captures between sched events and initcall events. So we get 
> rid of the old time capture by the boot tracer and split the 
> initcall events in two parts: call and return. This way we have the 
> ring buffer timestamp of both.
> 
> There is an example of a trace in attachment.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
>  include/trace/boot.h      |   31 ++++++++---
>  init/main.c               |   32 ++++++------
>  kernel/trace/trace.h      |   17 ++++--
>  kernel/trace/trace_boot.c |  123 ++++++++++++++++++++++++++++++++++-----------
>  4 files changed, 144 insertions(+), 59 deletions(-)

applied	to tip/tracing/fastboot, thanks	Frederic! 

one small detail, do we need these messages in the boot tracer:

  ##### CPU 1 buffer started ####

they are helpful for latency traces but might be confusing for boot 
traces. (they lose their attraction after having seen a dozen of them)

	Ingo

  reply	other threads:[~2008-11-12  9:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 22:24 [PATCH 2/2] tracing/fastboot: Use the ring-buffer timestamp for initcall entries Frederic Weisbecker
2008-11-12  9:25 ` Ingo Molnar [this message]
2008-11-12 10:58   ` Frédéric Weisbecker
2008-11-12 12:59   ` Steven Rostedt
2008-11-12 13:01     ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-11-12  5:54 [PATCH 0/2] boot tracer updates Steven Rostedt
2008-11-12  5:54 ` [PATCH 2/2] tracing/fastboot: Use the ring-buffer timestamp for initcall entries Steven Rostedt
2008-11-12  6:00   ` Andrew Morton
2008-11-12  8:45     ` Frédéric Weisbecker
2008-11-12 10:21       ` Ingo Molnar
2008-11-12 10:33         ` Frédéric Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112092548.GE4748@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox