From: Andy Whitcroft <apw@shadowen.org>
To: Dotan Barak <dotanba@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: checkpatch.pl print the line twice when trailing statements in the same line
Date: Wed, 12 Nov 2008 13:54:59 +0000 [thread overview]
Message-ID: <20081112135459.GC8302@shadowen.org> (raw)
In-Reply-To: <20081031082414.GD26593@brain>
On Fri, Oct 31, 2008 at 08:24:14AM +0000, Andy Whitcroft wrote:
> On Mon, Oct 20, 2008 at 08:51:38PM +0200, Dotan Barak wrote:
> > Hi.
> >
> > I executed checkpatch.pl version 0.24 on a file and i noticed that when
> > a tailing statement is being declared at the same line with "while, checkpatch
> > prints the erroneous line twice.
> >
> > Here is an example of the output:
> >
> > ERROR: trailing statements should be on next line
> > #651: FILE: idbm.c:651:
> > + while (*nl && isspace(c = *nl)) nl++;
> > + while (*nl && isspace(c = *nl)) nl++;
> >
> > Is this is the expected behavior?
>
> No that would definintaly not be expected. Will add it to my TODO list.
Ok, this is now fixed up and should be in my next batch of updates.
-apw
next prev parent reply other threads:[~2008-11-12 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 18:51 checkpatch.pl print the line twice when trailing statements in the same line Dotan Barak
2008-10-31 8:24 ` Andy Whitcroft
2008-11-12 13:54 ` Andy Whitcroft [this message]
2008-11-12 15:38 ` Dotan Barak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112135459.GC8302@shadowen.org \
--to=apw@shadowen.org \
--cc=dotanba@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox