From: Mark Brown <broonie@sirena.org.uk>
To: David Brownell <david-b@pacbell.net>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.28-rc3] regulator: add REGULATOR_MODE_OFF
Date: Wed, 12 Nov 2008 23:09:03 +0000 [thread overview]
Message-ID: <20081112230901.GA8272@sirena.org.uk> (raw)
In-Reply-To: <200811121342.36117.david-b@pacbell.net>
On Wed, Nov 12, 2008 at 01:42:35PM -0800, David Brownell wrote:
> On Wednesday 12 November 2008, Mark Brown wrote:
> > It should be a separate patch, I'd say.
> So you think I should split my "v2" patch in two chunks?
> One distinguishing requested-vs=actual mode, and the other
> allowing the actual mode to include OFF. (Possibly by just
> reporting mode 0 ...)
I would certainly keep OFF as a separate patch, yes.
> > Thinking about it I'm not sure if the hardware or logical state should
> > be the primary. In terms of debugging power consumption and so on the
> If there are both "requested opmode" and "opmode" attributes
> in sysfs, I don't see how one would be "primary"!
The one returned by the in-kernel get_mode() and reported as "opmode" is
what I'd think of as primary.
next prev parent reply other threads:[~2008-11-12 23:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-09 23:31 [patch 2.6.28-rc3] regulator: add REGULATOR_MODE_OFF David Brownell
2008-11-10 13:14 ` Liam Girdwood
2008-11-10 15:43 ` David Brownell
2008-11-10 16:56 ` Mark Brown
2008-11-11 4:56 ` David Brownell
2008-11-12 11:25 ` Mark Brown
2008-11-12 21:42 ` David Brownell
2008-11-12 23:09 ` Mark Brown [this message]
2008-11-12 22:23 ` Liam Girdwood
2008-11-13 0:00 ` David Brownell
2008-11-13 19:40 ` David Brownell
2008-11-13 21:53 ` Mark Brown
2008-11-15 1:15 ` David Brownell
2008-11-15 4:37 ` Mark Brown
2008-11-16 20:28 ` David Brownell
2008-11-16 22:58 ` David Brownell
2008-11-17 1:51 ` Mark Brown
2009-01-15 7:03 ` David Brownell
2009-01-15 12:29 ` Mark Brown
2009-01-15 22:32 ` David Brownell
2009-01-16 1:08 ` Mark Brown
2009-01-15 7:03 ` [patch 2.6.29-rc] regulator: add get_status() David Brownell
2009-01-15 12:04 ` Liam Girdwood
2009-01-15 12:40 ` Mark Brown
2009-01-15 12:50 ` Liam Girdwood
2009-01-15 15:35 ` David Brownell
2009-01-15 16:05 ` Mark Brown
2009-01-15 16:54 ` David Brownell
2009-01-15 18:11 ` David Brownell
2009-01-15 18:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112230901.GA8272@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox