From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Frédéric Weisbecker" <fweisbec@gmail.com>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tracing/function-return-tracer: Call prepare_ftrace_return by registers
Date: Thu, 13 Nov 2008 09:59:49 +0100 [thread overview]
Message-ID: <20081113085949.GG25479@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0811121911340.30248@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> >
> > Hmm... The whole thing is splitted in two levels: the infrastructure
> > to trace on call and return (and call
> > a return handler) and the higher level tracer.
> > The first could be called ftrace_exit because it is waht it does.
> > And the second is much more about cost evaluation of functions and so
> > could be named function_cost. Its
> > functions and structures could have this in their name whereas the low
> > level things could have ftrace_exit in
> > their name.
> >
> > What do you think?
>
> Yeah, I like that.
>
> Ingo, what's your thought on that?
hm, function-exit is a quite bad name i think that tells nothing to
the user. I like "function-cost tracer" because that tells the user
what it's all about in the end.
Or perhaps we could name it the "callgraph" tracer? (as opposed to the
simpler function tracer which traces function entries) Note that we
could use the output to build function call coverage graphs.
It definitely must convey the idea that this is a more capable (and
also more expensive) form of function tracing.
Ingo
next prev parent reply other threads:[~2008-11-13 9:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 21:49 [PATCH 2/2] tracing/function-return-tracer: Call prepare_ftrace_return by registers Frederic Weisbecker
2008-11-12 22:16 ` Ingo Molnar
2008-11-12 22:22 ` Frédéric Weisbecker
2008-11-12 23:25 ` Steven Rostedt
2008-11-12 23:35 ` Frédéric Weisbecker
2008-11-13 0:11 ` Steven Rostedt
2008-11-13 8:59 ` Ingo Molnar [this message]
2008-11-13 9:14 ` Ingo Molnar
2008-11-13 10:02 ` Frédéric Weisbecker
2008-11-13 10:09 ` Ingo Molnar
2008-11-13 23:48 ` Frédéric Weisbecker
2008-11-13 9:38 ` Frédéric Weisbecker
2008-11-13 9:40 ` Frédéric Weisbecker
2008-11-13 9:44 ` Ingo Molnar
2008-11-17 18:58 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113085949.GG25479@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox