From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrey Panin <pazke@donpac.ru>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] 8250: Oxford Semiconductor Devices
Date: Thu, 13 Nov 2008 09:59:25 +0000 [thread overview]
Message-ID: <20081113095925.4a3fea5d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20081113070756.GA30213@ports.donpac.ru>
> > + number_uarts = ioread8(p + 4);
> > + board->num_ports = number_uarts;
>
> Why not just return number of ports here ?
That would leak mappings
>
> > + printk(KERN_DEBUG
> > + "%d ports detected on Oxford PCI Express device\n",
> > + number_uarts);
>
> Is this printk really necessary ?
For the moment yes.
> WTF is this ? Why existing pci_serial_quirks[] infrastructure cannot be used here ?
Russell already fixed that and the change went upstream.
next prev parent reply other threads:[~2008-11-13 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 19:27 [PATCH 0/3] Small series of further hardware updates Alan Cox
2008-10-17 19:28 ` [PATCH 1/3] epca: Add infinite break support Alan Cox
2008-10-17 19:28 ` [PATCH 2/3] 8250: Oxford Semiconductor Devices Alan Cox
2008-10-20 16:46 ` Linus Torvalds
2008-11-12 7:33 ` Andrey Panin
2008-11-13 7:07 ` Andrey Panin
2008-11-13 9:59 ` Alan Cox [this message]
2008-11-13 15:48 ` Linus Torvalds
2008-10-17 19:29 ` [PATCH 3/3] 8250: Add more OxSemi devices Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113095925.4a3fea5d@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox