Re: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE_LX is defined

[Andres Salomon <dilinger@queued.net>]

On Thu, 13 Nov 2008 17:38:02 +0100
Pavel Machek <pavel@suse.cz> wrote:

> On Thu 2008-11-13 11:14:28, Andres Salomon wrote:
> > On Thu, 13 Nov 2008 16:54:19 +0100
> > Takashi Iwai <tiwai@suse.de> wrote:
> > 
> > > At Thu, 13 Nov 2008 16:37:14 +0100,
> > > Pavel Machek wrote:
> > [...]
> > > > 
> > > > > IMO, the basic problem is rather that the platform and the CPU
> > > > > selection is mixed up.  The geode GPIO stuff shouldn't belong
> > > > > to CPU selection.
> > > > 
> > > > ACK... and suggested patch makes it worse.
> > > > 
> > > > There should be option 'support OLPC' somewhere, and that should
> > > > enable the gpio bits. Alsa driver should depend on that one.
> > > 
> > > Any better fix patch is welcome, of course :)
> > > This would make save a lot time than writing mails...
> 
> > 
> > Okay, how about something like the following?
> 
> It is wrong. It is valid & useful to compile kernel for i386 and
> expect all the features on OLPC (with small performance hit).
> 
> 								Pavel

No one's debating that.  That requires additional work that will take
longer, however.