From: Felipe Balbi <me@felipebalbi.com>
To: Richard Purdie <rpurdie@linux.intel.com>
Cc: Felipe Balbi <me@felipebalbi.com>,
linux-kernel@vger.kernel.org,
Felipe Balbi <felipe.balbi@nokia.com>,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>, Greg KH <greg@kroah.com>,
Pierre Ossman <drzeus@drzeus.cx>
Subject: Re: [PATCH] led: simplify led_trigger_register_simple
Date: Thu, 13 Nov 2008 20:14:16 +0200 [thread overview]
Message-ID: <20081113181407.GC17166@frodo> (raw)
In-Reply-To: <1226579912.5402.21.camel@dax.rpnet.com>
On Thu, Nov 13, 2008 at 12:38:32PM +0000, Richard Purdie wrote:
> The simple triggers were designed to cause minimum interference to the
> usually external subsystem code they were added into. As an example this
> meant things like errors were just handled gracefully with a printk
> warning and did not take down the whole subsystem. I therefore don't
> regard this patch as a simplification, more a complication.
That's a matter of changing the return ERR_PTR(err); back to a printk.
--
balbi
next prev parent reply other threads:[~2008-11-13 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 3:09 [PATCH] led: simplify led_trigger_register_simple Felipe Balbi
2008-11-13 12:03 ` Anton Vorontsov
2008-11-13 12:38 ` Richard Purdie
2008-11-13 18:14 ` Felipe Balbi [this message]
2008-11-13 19:10 ` Felipe Balbi
2008-11-20 13:10 ` Felipe Balbi
2008-11-20 13:33 ` Richard Purdie
2008-11-20 14:14 ` Felipe Balbi
2008-11-20 14:45 ` Richard Purdie
2008-11-20 15:01 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113181407.GC17166@frodo \
--to=me@felipebalbi.com \
--cc=cbou@mail.ru \
--cc=drzeus@drzeus.cx \
--cc=dwmw2@infradead.org \
--cc=felipe.balbi@nokia.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox