From: Andrew Morton <akpm@linux-foundation.org>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -mm] vmscan: bail out of page reclaim after swap_cluster_max pages
Date: Thu, 13 Nov 2008 19:27:29 -0800 [thread overview]
Message-ID: <20081113192729.7d8eb133.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081113171208.6985638e@bree.surriel.com>
On Thu, 13 Nov 2008 17:12:08 -0500 Rik van Riel <riel@redhat.com> wrote:
> Sometimes the VM spends the first few priority rounds rotating back
> referenced pages and submitting IO. Once we get to a lower priority,
> sometimes the VM ends up freeing way too many pages.
>
> The fix is relatively simple: in shrink_zone() we can check how many
> pages we have already freed and break out of the loop.
>
> However, in order to do this we do need to know how many pages we already
> freed, so move nr_reclaimed into scan_control.
There was a reason for not doing this, but I forget what it was. It might require
some changelog archeology. iirc it was to do with balancing scanning rates
between the various things which we scan.
next prev parent reply other threads:[~2008-11-14 3:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 22:12 [PATCH -mm] vmscan: bail out of page reclaim after swap_cluster_max pages Rik van Riel
2008-11-14 0:51 ` KOSAKI Motohiro
2008-11-14 3:27 ` Andrew Morton [this message]
2008-11-14 14:36 ` Rik van Riel
2008-11-14 17:18 ` Andrew Morton
2008-11-16 7:43 ` KOSAKI Motohiro
2008-11-16 7:54 ` Andrew Morton
2008-11-16 7:56 ` KOSAKI Motohiro
2008-11-16 8:02 ` Andrew Morton
2008-11-22 10:22 ` KOSAKI Motohiro
2008-11-22 16:57 ` Rik van Riel
2008-11-24 19:12 ` KOSAKI Motohiro
2008-11-24 19:18 ` Rik van Riel
2008-11-16 7:38 ` KOSAKI Motohiro
2008-11-17 0:38 ` KAMEZAWA Hiroyuki
2008-11-17 3:43 ` Balbir Singh
2008-11-19 16:54 ` Mel Gorman
2008-11-21 11:59 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113192729.7d8eb133.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox