public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Eric Dumazet <dada1@cosmosbay.com>, Takashi Iwai <tiwai@suse.de>,
	Andreas Gruenbacher <agruen@suse.de>,
	Jan Blunck <jblunck@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>
Subject: Re: [PATCH] Allocate module.ref array dynamically
Date: Thu, 13 Nov 2008 19:51:06 +1030	[thread overview]
Message-ID: <200811131951.07686.rusty@rustcorp.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0811121630390.2379@quilx.com>

On Thursday 13 November 2008 09:20:46 Christoph Lameter wrote:
> The old api was based on an attempt to introduce a cpu mask. That mask was
> never used. See percpu_alloc_mask. The handling is not consistent with the
> nature of the percpu sections for other percpu data because allocation is
> only done for online processors. So we have semantic differences. The API
> is inconsistent and underwent rot.

Yes, but I was talking about the original percpu API: 
alloc_percpu/free_percpu/per_cpu_ptr.  That's the only bit that counts, as 
it's the only bit that's used.  Yes, the percpu_alloc should die.

Just convert *that API* to your new implementation, and drop all the 
conversion patches.  I said this back in June.

> The cpu alloc patchset gets rid of about half the hooks in the page
> allocator and slab allocator.

Sure, but we could convert those today to alloc_percpu etc.
Rusty.

  reply	other threads:[~2008-11-13  9:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 20:01 [PATCH] Allocate module.ref array dynamically Takashi Iwai
2008-11-11 22:06 ` Eric Dumazet
2008-11-11 22:15   ` Eric Dumazet
2008-11-11 22:32     ` Takashi Iwai
2008-11-11 22:26   ` Takashi Iwai
2008-11-12  1:44   ` Rusty Russell
2008-11-12  2:26     ` Mike Travis
2008-11-12  3:17       ` Christoph Lameter
2008-11-12 13:46         ` Mike Travis
2008-11-12  3:14     ` Christoph Lameter
2008-11-12  9:59       ` Rusty Russell
2008-11-12 20:11         ` Christoph Lameter
2008-11-12 22:01           ` Rusty Russell
2008-11-12 22:50             ` Christoph Lameter
2008-11-13  9:21               ` Rusty Russell [this message]
2008-11-13 14:40                 ` Christoph Lameter
2008-11-13 23:49                   ` Rusty Russell
2008-11-14  0:20                     ` Christoph Lameter
2008-11-16  0:00                       ` Rusty Russell
2008-11-16 21:41                         ` Rusty Russell
2008-11-20 16:47                         ` Christoph Lameter
2008-11-20 23:21                           ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811131951.07686.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=agruen@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=dada1@cosmosbay.com \
    --cc=jblunck@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox