Re: [GIT PATCH] USB patches for 2.6-git

Greg KH
2008-11-14T20:56:48Z

On Fri, Nov 14, 2008 at 11:10:32PM +0300, Sergei Shtylyov wrote:
> Greg KH wrote:
>
>>>>> There is a difference in the musb patch I submitted and the one which
>>>>> actually has been
>>>>> forwarded to you by Felipe. This difference has introduced a bug.
>
>>>>> The patch in you series is,
>>>>> usb: musb: fix BULK request on different available endpoints
>
>>>>> It was submitted by me at,
>>>>> http://marc.info/?l=linux-usb&m=122337227617797&w=2
>
>>>>> And the one which is forwarded to you by Felipe is at,
>>>>> http://marc.info/?l=linux-usb&m=122528597316728&w=2
>
>>>>> There is a difference in between above two as below.
>>>>> Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
>>>>> Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK)
>>>>> {
>
>>>>> It should be [best_end < 0].
>
>>>>> If it is possible then please correct this mismatch in your series.
>
>>>> I'll wait to get a patch from Felipe for this.
>
>>> I'm seeing it being to you sent at least a week ago -- look for "usb:
>>> musb: fix bug in musb_schedule".
>
>> As Felipe is the maintainer of the musb code, and has been batching up
>> patches and sending them on to me when needed, I have only been taking
>> them from him.
>
>> So that message is long deleted from my mail, sorry.
>
> Even though it was a message from him CCing you? :-)
> Here it is: http://marc.info/?l=linux-usb&m=122605639520312.

Nope, I'm not on the CC: for that message, sorry, check your headers...

thanks,

greg k-h