From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: linux-serial@vger.kernel.org, akpm@linux-foundation.org,
dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix an uninitialised variable warning in the 8250 driver
Date: Fri, 14 Nov 2008 16:34:28 +0000 [thread overview]
Message-ID: <20081114163428.7b676742@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20081114162038.23016.20581.stgit@warthog.procyon.org.uk>
On Fri, 14 Nov 2008 16:20:38 +0000
David Howells <dhowells@redhat.com> wrote:
> Fix an uninitialised variable warning in the 8250 driver:
>
> CC drivers/serial/8250.o
> drivers/serial/8250.c: In function 'serial8250_shutdown':
> drivers/serial/8250.c:1612: warning: 'i' may be used uninitialized in this function
Current versions of gcc that I've tested get this all correct just fine
for x86 at least.
Do check that the BUG_ON() helper for whatever platform you are using
needs to correctly indicate that its BUG spewing path may not return
(__attibute((__noreturn__)). I seem to remember some of the architectures
are broken on that.
Alan
next prev parent reply other threads:[~2008-11-14 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 16:20 [PATCH] Fix an uninitialised variable warning in the 8250 driver David Howells
2008-11-14 16:34 ` Alan Cox [this message]
2008-11-14 16:51 ` David Howells
2008-11-14 19:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081114163428.7b676742@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox