Re: mmotm 2008-11-14-17-14 uploaded

Re: mmotm 2008-11-14-17-14 uploaded

[KAMEZAWA Hiroyuki]

On Fri, 14 Nov 2008 17:15:12 -0800
akpm@linux-foundation.org wrote:

> The mm-of-the-moment snapshot 2008-11-14-17-14 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc4:
> 
Sorry..

  CC      arch/x86/kernel/asm-offsets.s
In file included from include/linux/swap.h:8,
                 from include/linux/suspend.h:7,
                 from arch/x86/kernel/asm-offsets_64.c:12,
                 from arch/x86/kernel/asm-offsets.c:4:
include/linux/memcontrol.h: In function 'mem_cgroup_disabled':
include/linux/memcontrol.h:93: error: 'mem_cgroup_subsys' undeclared (first use in this function)
include/linux/memcontrol.h:93: error: (Each undeclared identifier is reported only once
include/linux/memcontrol.h:93: error: for each function it appears in.)

This is
memcg-add-mem_cgroup_disabled-fix.patch
=


Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 include/linux/memcontrol.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: mmotm-2.6.28-Nov14/include/linux/memcontrol.h
===================================================================
--- mmotm-2.6.28-Nov14.orig/include/linux/memcontrol.h
+++ mmotm-2.6.28-Nov14/include/linux/memcontrol.h
@@ -19,7 +19,7 @@
 
 #ifndef _LINUX_MEMCONTROL_H
 #define _LINUX_MEMCONTROL_H
-
+#include <linux/cgroup.h>
 struct mem_cgroup;
 struct page_cgroup;
 struct page;

Re: mmotm 2008-11-14-17-14 uploaded

[KAMEZAWA Hiroyuki]

Sorry, again.
a fix for memcg-add-mem_cgroup_disabled-fix.patch
please ignore previous mail...

==

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 include/linux/memcontrol.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: mmotm-2.6.28-Nov14/include/linux/memcontrol.h
===================================================================
--- mmotm-2.6.28-Nov14.orig/include/linux/memcontrol.h
+++ mmotm-2.6.28-Nov14/include/linux/memcontrol.h
@@ -19,7 +19,7 @@
 
 #ifndef _LINUX_MEMCONTROL_H
 #define _LINUX_MEMCONTROL_H
-
+#include <linux/cgroup.h>
 struct mem_cgroup;
 struct page_cgroup;
 struct page;
Index: mmotm-2.6.28-Nov14/mm/memcontrol.c
===================================================================
--- mmotm-2.6.28-Nov14.orig/mm/memcontrol.c
+++ mmotm-2.6.28-Nov14/mm/memcontrol.c
@@ -301,7 +301,7 @@ void mem_cgroup_rotate_lru_list(struct p
 	struct mem_cgroup_per_zone *mz;
 	struct page_cgroup *pc;
 
-	if (mem_cgroup_diabled())
+	if (mem_cgroup_disabled())
 		return;
 
 	pc = lookup_page_cgroup(page);

Re: mmotm 2008-11-14-17-14 uploaded

[KAMEZAWA Hiroyuki]

On Fri, 14 Nov 2008 17:15:12 -0800
akpm@linux-foundation.org wrote:

> The mm-of-the-moment snapshot 2008-11-14-17-14 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc4:
> 
I saw this.
==
fs/dquot.c:1391: error: redefinition of '__kcrctab_dquot_reserve_space'
fs/dquot.c:1352: error: previous definition of '__kcrctab_dquot_reserve_space' was here
fs/dquot.c:1391: error: redefinition of '__kstrtab_dquot_reserve_space'
fs/dquot.c:1352: error: previous definition of '__kstrtab_dquot_reserve_space' was here
fs/dquot.c:1391: error: redefinition of '__ksymtab_dquot_reserve_space'
fs/dquot.c:1352: error: previous definition of '__ksymtab_dquot_reserve_space' was here
fs/dquot.c:2101: error: redefinition of '__kcrctab_vfs_dq_quota_on_remount'
fs/dquot.c:1974: error: previous definition of '__kcrctab_vfs_dq_quota_on_remount' was here
fs/dquot.c:2101: error: redefinition of '__kstrtab_vfs_dq_quota_on_remount'
fs/dquot.c:1974: error: previous definition of '__kstrtab_vfs_dq_quota_on_remount' was here
fs/dquot.c:2101: error: redefinition of '__ksymtab_vfs_dq_quota_on_remount'
fs/dquot.c:1974: error: previous definition of '__ksymtab_vfs_dq_quota_on_remount' was here
make[1]: *** [fs/dquot.o] Error 1
==

and this may be a patch.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
==
---
 fs/dquot.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: mmotm-2.6.28-Nov13/fs/dquot.c
===================================================================
--- mmotm-2.6.28-Nov13.orig/fs/dquot.c
+++ mmotm-2.6.28-Nov13/fs/dquot.c
@@ -1388,7 +1388,7 @@ int dquot_claim_space(struct inode *inod
 	inode_add_bytes(inode, number);
 	return ret;
 }
-EXPORT_SYMBOL(dquot_reserve_space);
+EXPORT_SYMBOL(dquot_claim_space);
 
 /*
  * Release reserved quota space
@@ -1971,7 +1971,7 @@ static int vfs_quota_on_remount(struct s
 
 	return ret;
 }
-EXPORT_SYMBOL(vfs_dq_quota_on_remount);
+EXPORT_SYMBOL(vfs_quota_on_remount);
 
 int vfs_quota_on_path(struct super_block *sb, int type, int format_id,
 		      struct path *path)
@@ -2277,6 +2277,7 @@ out:
 	mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex);
 	return err;
 }
+EXPORT_SYMBOL(vfs_set_dqinfo);
 
 struct quotactl_ops vfs_quotactl_ops = {
 	.quota_on	= vfs_quota_on,

Re: mmotm 2008-11-14-17-14 uploaded

[KAMEZAWA Hiroyuki]

On Fri, 14 Nov 2008 17:15:12 -0800
akpm@linux-foundation.org wrote:

> The mm-of-the-moment snapshot 2008-11-14-17-14 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc4:
> 

shows
  MODPOST 771 modules
ERROR: "global_cifs_sock_list" [fs/cifs/cifs.ko] undefined!
make[1]: *** [__modpost] Error 1

Maybe this ?
patches/cifs-remove-global_extern-macro.patch

Thanks,
-Kame

Re: mmotm 2008-11-14-17-14 uploaded

[Andrew Morton]

On Sat, 15 Nov 2008 13:28:11 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

> On Fri, 14 Nov 2008 17:15:12 -0800
> akpm@linux-foundation.org wrote:
> 
> > The mm-of-the-moment snapshot 2008-11-14-17-14 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > It contains the following patches against 2.6.28-rc4:
> > 
> 
> shows
>   MODPOST 771 modules
> ERROR: "global_cifs_sock_list" [fs/cifs/cifs.ko] undefined!
> make[1]: *** [__modpost] Error 1
> 
> Maybe this ?
> patches/cifs-remove-global_extern-macro.patch
> 

Could be.  That GLOBAL_EXTERN thing should be held on the ground whilst
farm animals poop on its head, but my attempts to remove it have thus
far fallen on deaf inboxes.

I'll give up.