public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
	Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
	Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Eilon Greenstein <eilong@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	Alex Chiang <achiang@hp.com>
Subject: [patch 05/22] bnx2x: Removing the PMF indication when unloading
Date: Fri, 14 Nov 2008 21:22:58 -0800	[thread overview]
Message-ID: <20081115052258.GF3710@kroah.com> (raw)
In-Reply-To: <20081115052220.GA3710@kroah.com>

[-- Attachment #1: bnx2x-removing-the-pmf-indication-when-unloading.patch --]
[-- Type: text/plain, Size: 1244 bytes --]

2.6.27-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Eilon Greenstein <eilong@broadcom.com>

commit 9a0354405feb0f8bd460349a93db05e4cca8d166 upstream.

When the PMF flag is set, the driver can access the HW freely. When the
driver is unloaded, it should not access the HW. The problem caused fatal
errors when "ethtool -i" was called after the calling instance was unloaded
and another instance was already loaded

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Alex Chiang <achiang@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/net/bnx2x_main.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -6480,6 +6480,7 @@ load_int_disable:
 	bnx2x_free_irq(bp);
 load_error:
 	bnx2x_free_mem(bp);
+	bp->port.pmf = 0;
 
 	/* TBD we really need to reset the chip
 	   if we want to recover from this */
@@ -6790,6 +6791,7 @@ unload_error:
 	/* Report UNLOAD_DONE to MCP */
 	if (!BP_NOMCP(bp))
 		bnx2x_fw_command(bp, DRV_MSG_CODE_UNLOAD_DONE);
+	bp->port.pmf = 0;
 
 	/* Free SKBs, SGEs, TPA pool and driver internals */
 	bnx2x_free_skbs(bp);

-- 

  parent reply	other threads:[~2008-11-15  5:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081115051732.506914008@mini.kroah.org>
2008-11-15  5:22 ` [patch 00/22] 2.6.27.7-stable review Greg KH
2008-11-15  5:22   ` [patch 01/22] touch_mnt_namespace when the mount flags change Greg KH
2008-11-15  5:22   ` [patch 02/22] iwlagn: avoid sleep in softirq context Greg KH
2008-11-15  5:22   ` [patch 03/22] ath5k: fix suspend-related oops on rmmod Greg KH
2008-11-15  5:22   ` [patch 04/22] ath5k: Fix reset sequence for AR5212 in general and RF5111 in particular Greg KH
2008-11-15  5:22   ` Greg KH [this message]
2008-11-15  5:23   ` [patch 06/22] bnx2x: PCI configuration bug on big-endian Greg KH
2008-11-15  5:23   ` [patch 07/22] bnx2x: Calling netif_carrier_off at the end of the probe Greg KH
2008-11-15  5:23   ` [patch 08/22] ARM: 5329/1: Feroceon: fix feroceon_l2_inv_range Greg KH
2008-11-15  5:23   ` [patch 09/22] Fix platform drivers that crash on suspend/resume Greg KH
2008-11-15  5:23   ` [patch 10/22] hostap: pad the skb->cb usage in lieu of a proper fix Greg KH
2008-11-15  5:23   ` [patch 11/22] ACPI: avoid empty file name in sysfs Greg KH
2008-11-15  5:23   ` [patch 12/22] ACPI: EC: make kernel messages more useful when GPE storm is detected Greg KH
2008-11-15  5:23   ` [patch 13/22] hugetlb: make unmap_ref_private multi-size-aware Greg KH
2008-11-15  5:23   ` [patch 14/22] rtl8187: Add Abocom USB ID Greg KH
2008-11-15  5:23   ` [patch 15/22] rtl8187 : support for Sitecom WL-168 0001 v4 Greg KH
2008-11-15  5:23   ` [patch 16/22] kbuild: Fixup deb-pkg target to generate separate firmware deb Greg KH
2008-11-15  5:23   ` [patch 17/22] block: fix nr_phys_segments miscalculation bug Greg KH
2008-11-15  5:23   ` [patch 18/22] powerpc/mpic: Fix regression caused by change of default IRQ affinity Greg KH
2008-11-15  5:23   ` [patch 19/22] Input: ALPS - add signature for DualPoint found in Dell Latitude E6500 Greg KH
2008-11-15  5:23   ` [patch 20/22] memory hotplug: fix page_zone() calculation in test_pages_isolated() Greg KH
2008-11-15  5:23   ` [patch 21/22] r8169: select MII in Kconfig Greg KH
2008-11-15  5:24   ` [patch 22/22] sony-laptop: ignore missing _DIS method on pic device Greg KH
2008-11-16 10:38   ` [patch 00/22] 2.6.27.7-stable review François Valenduc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081115052258.GF3710@kroah.com \
    --to=gregkh@suse.de \
    --cc=achiang@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=eteo@redhat.com \
    --cc=jake@lwn.net \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rbranco@la.checkpoint.com \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox