From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
Chuck Ebbert <cebbert@redhat.com>,
Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk,
Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>
Subject: [patch 10/22] hostap: pad the skb->cb usage in lieu of a proper fix
Date: Fri, 14 Nov 2008 21:23:16 -0800 [thread overview]
Message-ID: <20081115052316.GK3710@kroah.com> (raw)
In-Reply-To: <20081115052220.GA3710@kroah.com>
[-- Attachment #1: hostap-pad-the-skb-cb-usage-in-lieu-of-a-proper-fix.patch --]
[-- Type: text/plain, Size: 1570 bytes --]
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: Johannes Berg <johannes@sipsolutions.net>
commit f7cd168645dda3e9067f24fabbfa787f9a237488 upstream.
Like mac80211 did, this driver makes 'clever' use of skb->cb to pass
information along with an skb as it is requeued from the virtual device
to the physical wireless device. Unfortunately, that trick no longer
works...
Unlike mac80211, code complexity and driver apathy makes this hack
the best option we have in the short run. Hopefully someone will
eventually be motivated to code a proper fix before all the effected
hardware dies.
(Above text by me. Johannes officially disavows all knowledge of this
hack. -- JWL)
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/net/wireless/hostap/hostap_wlan.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/hostap/hostap_wlan.h
+++ b/drivers/net/wireless/hostap/hostap_wlan.h
@@ -918,9 +918,12 @@ struct hostap_interface {
/*
* TX meta data - stored in skb->cb buffer, so this must not be increased over
- * the 40-byte limit
+ * the 48-byte limit.
+ * THE PADDING THIS STARTS WITH IS A HORRIBLE HACK THAT SHOULD NOT LIVE
+ * TO SEE THE DAY.
*/
struct hostap_skb_tx_data {
+ unsigned int __padding_for_default_qdiscs;
u32 magic; /* HOSTAP_SKB_TX_DATA_MAGIC */
u8 rate; /* transmit rate */
#define HOSTAP_TX_FLAGS_WDS BIT(0)
--
next prev parent reply other threads:[~2008-11-15 5:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081115051732.506914008@mini.kroah.org>
2008-11-15 5:22 ` [patch 00/22] 2.6.27.7-stable review Greg KH
2008-11-15 5:22 ` [patch 01/22] touch_mnt_namespace when the mount flags change Greg KH
2008-11-15 5:22 ` [patch 02/22] iwlagn: avoid sleep in softirq context Greg KH
2008-11-15 5:22 ` [patch 03/22] ath5k: fix suspend-related oops on rmmod Greg KH
2008-11-15 5:22 ` [patch 04/22] ath5k: Fix reset sequence for AR5212 in general and RF5111 in particular Greg KH
2008-11-15 5:22 ` [patch 05/22] bnx2x: Removing the PMF indication when unloading Greg KH
2008-11-15 5:23 ` [patch 06/22] bnx2x: PCI configuration bug on big-endian Greg KH
2008-11-15 5:23 ` [patch 07/22] bnx2x: Calling netif_carrier_off at the end of the probe Greg KH
2008-11-15 5:23 ` [patch 08/22] ARM: 5329/1: Feroceon: fix feroceon_l2_inv_range Greg KH
2008-11-15 5:23 ` [patch 09/22] Fix platform drivers that crash on suspend/resume Greg KH
2008-11-15 5:23 ` Greg KH [this message]
2008-11-15 5:23 ` [patch 11/22] ACPI: avoid empty file name in sysfs Greg KH
2008-11-15 5:23 ` [patch 12/22] ACPI: EC: make kernel messages more useful when GPE storm is detected Greg KH
2008-11-15 5:23 ` [patch 13/22] hugetlb: make unmap_ref_private multi-size-aware Greg KH
2008-11-15 5:23 ` [patch 14/22] rtl8187: Add Abocom USB ID Greg KH
2008-11-15 5:23 ` [patch 15/22] rtl8187 : support for Sitecom WL-168 0001 v4 Greg KH
2008-11-15 5:23 ` [patch 16/22] kbuild: Fixup deb-pkg target to generate separate firmware deb Greg KH
2008-11-15 5:23 ` [patch 17/22] block: fix nr_phys_segments miscalculation bug Greg KH
2008-11-15 5:23 ` [patch 18/22] powerpc/mpic: Fix regression caused by change of default IRQ affinity Greg KH
2008-11-15 5:23 ` [patch 19/22] Input: ALPS - add signature for DualPoint found in Dell Latitude E6500 Greg KH
2008-11-15 5:23 ` [patch 20/22] memory hotplug: fix page_zone() calculation in test_pages_isolated() Greg KH
2008-11-15 5:23 ` [patch 21/22] r8169: select MII in Kconfig Greg KH
2008-11-15 5:24 ` [patch 22/22] sony-laptop: ignore missing _DIS method on pic device Greg KH
2008-11-16 10:38 ` [patch 00/22] 2.6.27.7-stable review François Valenduc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081115052316.GK3710@kroah.com \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cavokz@gmail.com \
--cc=cebbert@redhat.com \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=eteo@redhat.com \
--cc=jake@lwn.net \
--cc=jmforbes@linuxtx.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mkrufky@linuxtv.org \
--cc=rbranco@la.checkpoint.com \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox