From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: laijs@cn.fujitsu.com, akpm@linux-foundation.org,
kamezawa.hiroyu@jp.fujitsu.com, balbir@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] memcontrol: use simple_malloc()/simple_free()
Date: Sun, 16 Nov 2008 00:16:37 -0800 (PST) [thread overview]
Message-ID: <20081116.001637.76266244.davem@davemloft.net> (raw)
In-Reply-To: <20081116045128.GB24624@x200.localdomain>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Sun, 16 Nov 2008 07:51:28 +0300
> On Sun, Nov 16, 2008 at 12:33:46PM +0800, Lai Jiangshan wrote:
> > use simple_malloc()/simple_free() instead of current codes.
>
> struct mem_cgroup can't reach the size when kmalloc starts failing.
That's not the point.
When you got past a page, kmalloc/gfp allocations are less reliable,
and people also want NUMA spreading when possible.
That's why we use PAGE_SIZE as the table vmalloc() breakpoint. We do
this in many places already, with the exact same heuristics, and
for the exact same reasons.
prev parent reply other threads:[~2008-11-16 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 4:33 [PATCH 3/7] memcontrol: use simple_malloc()/simple_free() Lai Jiangshan
2008-11-16 4:51 ` Alexey Dobriyan
2008-11-16 4:54 ` Alexey Dobriyan
2008-11-17 0:09 ` KAMEZAWA Hiroyuki
2008-11-16 5:01 ` Lai Jiangshan
2008-11-16 8:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081116.001637.76266244.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox