Re: [PATCH 0/7] Porting dynmaic ftrace to PowerPC

Steven Rostedt
2008-11-19T03:04:45Z

On Wed, 19 Nov 2008, Paul Mackerras wrote:

> Steven Rostedt writes:
>
> > Can I add your Acked-by: to all these patches that I submitted? I'm going
> > to recommit them with a consistent subject (all lower case ppc), but I'm
> > not going to change the patches themselves.
> >
> > Would you two be fine with that? Or at least one of you?
>
> My preference would be for the patches to go through the powerpc tree
> unless there is a good reason for them to go via another tree.

I have no problem with that. The only thing is that we have a lot of
pending work still in the linux-tip tree, which you may need to pull
in to get these patches working. Well, there's two or three commits in the
generic code that I know the PPC code is dependent on.

I could give you a list of commits in tip that need to go mainline first
before we can pull in the PPC changes. Then you could wait till those
changes make it into 29 and then you could push the PPC modifications in
from your tree.

>
> The style we use for the headline is "powerpc: Add xyz feature" or
> "powerpc/subsystem: Fix foo bug".

We've been using the "ftrace: subject" format for most of our ftrace
commits, and have been using "ftrace, ppc: subject" or ppc32 or ppc64 for
those. But since this is a powerpc port, I will conform to your style.

>
> As for the acked-by, I feel I first need to go through the whole
> series again with the changes you have made recently. Have you
> reworked the earlier patches to avoid introducing any bugs, rather
> than just fixing the bugs with later patches? If you haven't, are you
> sure that the bugs won't cause any problems in bisecting?

Fair enough. I'll rework the patches again to fold back in the changes
based on your comments, as well as the comments of others. When I'm done,
I'll repost to the list. This way, if you pull them in, you can add your
Signed-off-by yourself.

>
> Also, what's the best place to find the latest patch set?

I'll be keeping the changes in my repo:

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

branch tip/ppc

Note, this branch is based on top of Ingo's linux-tip tree. I can make a
a branch "ppc" that will be based on top of mainline, and I can add the
patches needed to get PPC working. The generic commits will have the
"ftrace: " format.

The generic ftrace patches will still need to go in through linux-tip. But
when they do, feel free to push the PowerPC port in. Anyway, you are the
ones that can test it better than we can. I have two PPC boxes that I test
on, but I'm sure you have a lot more.

>
> Thanks again for doing all this work.

Thank you for the reviews.

-- Steve