From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Palfrader <peter@palfrader.org>, linux-kernel@vger.kernel.org
Subject: Re: Fix broken ownership of /proc/sys/ files
Date: Mon, 17 Nov 2008 04:06:45 +0000 [thread overview]
Message-ID: <20081117040645.GS28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.0811161515040.9657@nehalem.linux-foundation.org>
On Sun, Nov 16, 2008 at 03:23:47PM -0800, Linus Torvalds wrote:
>
>
> On Sun, 16 Nov 2008, Al Viro wrote:
> >
> > D'oh...
>
> So I applied this, but I wonder if it might not be nice to make
> new_inode() (or rather - 'alloc_inode()') initialize some more of the
> really core members.
>
> We already initialize a _lot_ of fields, including fields that most
> filesystem would likely end up re-initializing when reading an inode (like
> i_size and i_nlink). Maybe it would be more sensible to initialize
> i_gid/uid there too, when we are guaranteed to have that cacheline dirty
> anyway (because we're initializing everything around those fields).
*nod*
It certainly makes sense to do it in a uniform way - there's enough
users of new_inode() that want exactly that. I'll do that as soon
as I get from under a huge pile of pending mail ;-/
ObPendingStuff: would you mind a series of section annotations? That's
a bunch of trivial one-liners and it kills the section noise - the remaining
ones are few and tricky. It had sat around in my tree for several weeks
and I can certainly carry it until the next cycle, but OTOH this stuff
*is* trivial and the noise is annoying as hell.
next prev parent reply other threads:[~2008-11-17 4:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 20:59 broken ownership of /proc/sys/ files on 2.6.27 Peter Palfrader
2008-11-16 21:31 ` Rafael J. Wysocki
2008-11-16 21:33 ` Frans Pop
2008-11-16 21:36 ` Maxim Levitsky
2008-11-16 21:41 ` Måns Rullgård
2008-11-16 22:06 ` Bernd Zeimetz
2008-11-16 22:19 ` Al Viro
2008-11-16 22:37 ` Peter Palfrader
2008-11-16 22:44 ` Jiri Slaby
2008-11-16 22:56 ` Al Viro
2008-11-16 23:23 ` Fix broken ownership of /proc/sys/ files Linus Torvalds
2008-11-17 4:06 ` Al Viro [this message]
2008-11-17 18:50 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117040645.GS28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@palfrader.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox