public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: 2.6.28-rc5: unused variable in pagetable_init
Date: Mon, 17 Nov 2008 06:53:12 +0300	[thread overview]
Message-ID: <200811170653.16528.arvidjaar@mail.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

  CC      arch/x86/mm/init_32.o
/home/bor/src/linux-git/arch/x86/mm/init_32.c: In function ‘pagetable_init’:
/home/bor/src/linux-git/arch/x86/mm/init_32.c:515: warning: unused variable ‘pgd_base’

Well, pagetable_init is noop unless HIGHMEM is defined so it could be
as simple as that.

Or is something else expected to go into pagetable_init for more general
case?

--- arch/x86/mm/init_32.c       2008-11-10 06:19:14.000000000 +0300
+++ /tmp/init_32.c      2008-11-17 06:52:21.383685722 +0300
@@ -435,9 +435,17 @@ static void __init set_highmem_pages_ini
 }
 #endif /* !CONFIG_NUMA */

+static void __init pagetable_init(void)
+{
+       pgd_t *pgd_base = swapper_pg_dir;
+
+       permanent_kmaps_init(pgd_base);
+}
+
 #else
 # define permanent_kmaps_init(pgd_base)                do { } while (0)
 # define set_highmem_pages_init()      do { } while (0)
+# define pagetable_init()      do { } while (0)
 #endif /* CONFIG_HIGHMEM */

 void __init native_pagetable_setup_start(pgd_t *base)
@@ -510,13 +518,6 @@ static void __init early_ioremap_page_ta
        early_ioremap_reset();
 }

-static void __init pagetable_init(void)
-{
-       pgd_t *pgd_base = swapper_pg_dir;
-
-       permanent_kmaps_init(pgd_base);
-}
-
 #ifdef CONFIG_ACPI_SLEEP
 /*
  * ACPI suspend needs this for resume, because things like the intel-agp

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2008-11-17  3:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  3:53 Andrey Borzenkov [this message]
2008-11-17  8:25 ` 2.6.28-rc5: unused variable in pagetable_init Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811170653.16528.arvidjaar@mail.ru \
    --to=arvidjaar@mail.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox