public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Steven Noonan <steven@uplinklabs.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] tracing/ftrace: make nop tracer using tracer flags
Date: Mon, 17 Nov 2008 09:46:38 +0100	[thread overview]
Message-ID: <20081117084638.GC28786@elte.hu> (raw)
In-Reply-To: <4920D494.1010108@gmail.com>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> +#define TRACE_NOP_OPT_ACCEPT	0x1
> +#define TRACE_NOP_OPT_REFUSE	0x2

please use C enums not CPP defines.

	Ingo

  parent reply	other threads:[~2008-11-17  8:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  2:19 [PATCH 2/3] tracing/ftrace: make nop tracer using tracer flags Frederic Weisbecker
2008-11-17  2:36 ` Steven Noonan
2008-11-17  2:59   ` Frederic Weisbecker
2008-11-18 10:12     ` Ingo Molnar
2008-11-18 14:17       ` Steven Rostedt
2008-11-17  8:46 ` Ingo Molnar [this message]
2008-11-17 18:26   ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081117084638.GC28786@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=steven@uplinklabs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox