From: Ingo Molnar <mingo@elte.hu>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Tejun Heo <htejun@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
Hugh Dickins <hugh@veritas.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] Fix kunmap() argument in sg_miter_stop
Date: Mon, 17 Nov 2008 09:50:46 +0100 [thread overview]
Message-ID: <20081117085046.GE28786@elte.hu> (raw)
In-Reply-To: <20081117083022.GE26778@kernel.dk>
* Jens Axboe <jens.axboe@oracle.com> wrote:
> On Mon, Nov 17 2008, Ingo Molnar wrote:
> >
> > * Jens Axboe <jens.axboe@oracle.com> wrote:
> >
> > > +#define kunmap(p) \
> > > + do { \
> > > + struct page *__p; \
> > > + (void) (&__p == &(p)); \
> > > + __kunmap(p); \
> > > + } while (0)
> > > +
> > > +#define kunmap_atomic(a, t) \
> > > + do { \
> > > + void *__p; \
> > > + (void) (&__p == &(a)); \
> > > + __kunmap_atomic(a, t); \
> > > + } while (0)
> >
> > Agreed - but please use the typecheck() primitive. (linux/typecheck.h)
>
> Neat, didn't know about that, thanks.
and ack on your patch obviously. Feel free to push it via the block
tree straight away, it doesnt collide with anything pending in the x86
tree.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2008-11-17 8:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 19:27 [PATCH] Fix kunmap() argument in sg_miter_stop Arjan van de Ven
2008-11-15 20:15 ` Hugh Dickins
2008-11-15 20:27 ` Arjan van de Ven
2008-11-15 20:39 ` Arjan van de Ven
2008-11-16 5:16 ` Tejun Heo
2008-11-17 8:11 ` Jens Axboe
2008-11-17 8:22 ` Ingo Molnar
2008-11-17 8:30 ` Jens Axboe
2008-11-17 8:50 ` Ingo Molnar [this message]
2008-11-17 8:58 ` Jens Axboe
2008-11-17 9:34 ` Jens Axboe
2008-11-17 9:41 ` Ingo Molnar
2008-11-17 9:45 ` Jens Axboe
2008-11-17 11:13 ` Jens Axboe
2008-11-17 17:08 ` Jeremy Fitzhardinge
2008-11-17 17:10 ` Ingo Molnar
2008-11-17 17:15 ` Jeremy Fitzhardinge
2008-11-17 17:25 ` Linus Torvalds
2008-11-17 17:35 ` Jeremy Fitzhardinge
2008-11-17 18:14 ` [PATCH] xen: fix scrub_page() Ingo Molnar
2008-11-17 18:07 ` [PATCH] Fix kunmap() argument in sg_miter_stop Jens Axboe
2008-11-17 18:16 ` Linus Torvalds
2008-11-17 18:26 ` Jens Axboe
2008-11-18 8:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117085046.GE28786@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=htejun@gmail.com \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox