Re: [PATCH] Fix kunmap() argument in sg_miter_stop

Ingo Molnar
2008-11-17T08:51:20Z

* Jens Axboe <jens.axboe@oracle.com> wrote:

> On Mon, Nov 17 2008, Ingo Molnar wrote:
> >
> > * Jens Axboe <jens.axboe@oracle.com> wrote:
> >
> > > +#define kunmap(p) \
> > > + do { \
> > > + struct page *__p; \
> > > + (void) (&__p == &(p)); \
> > > + __kunmap(p); \
> > > + } while (0)
> > > +
> > > +#define kunmap_atomic(a, t) \
> > > + do { \
> > > + void *__p; \
> > > + (void) (&__p == &(a)); \
> > > + __kunmap_atomic(a, t); \
> > > + } while (0)
> >
> > Agreed - but please use the typecheck() primitive. (linux/typecheck.h)
>
> Neat, didn't know about that, thanks.

and ack on your patch obviously. Feel free to push it via the block
tree straight away, it doesnt collide with anything pending in the x86
tree.

Acked-by: Ingo Molnar <mingo@elte.hu>

Ingo