Re: [PATCH] Fix kunmap() argument in sg_miter_stop

Linus Torvalds
2008-11-17T18:17:12Z

On Mon, 17 Nov 2008, Jens Axboe wrote:
>
> Any opinions on the kunmap/kunmap_atomic pointer checking? It's a bit
> ugly that we have to enforce a void * rule for kunmap_atomic(),

I don't think that's a "bit ugly". I think it's unacceptable.

Making sure we pass in "struct page" to kunmap() sounds good, but the
kunmap_atomic() part just sounds insane.

Linus