From: Frederik Deweerdt <frederik.deweerdt@xprog.eu>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Richard Purdie <rpurdie@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Add WM8350 LED driver
Date: Mon, 17 Nov 2008 16:25:06 +0100 [thread overview]
Message-ID: <20081117152506.GA29949@gambetta> (raw)
In-Reply-To: <1226933529-13070-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hello Mark,
On Mon, Nov 17, 2008 at 02:52:09PM +0000, Mark Brown wrote:
[...]
> +/* Microamps */
> +static const int isink_cur[] = {
[...]
> + 223191
> +};
> +
[...]
> + for (i = 0; i < ARRAY_SIZE(isink_cur); i++)
> + if (isink_cur[i] >= pdata->max_uA)
> + break;
> + led->max_uA_index = i;
> + if (pdata->max_uA != isink_cur[i])
^^^
I may be missing something but isn't the code doing an off-by-one here
if pdata->max_uA > 223191 ?
Regards,
Frederik
next prev parent reply other threads:[~2008-11-17 15:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 14:52 [PATCH] leds: Add WM8350 LED driver Mark Brown
2008-11-17 15:25 ` Frederik Deweerdt [this message]
2008-11-17 15:29 ` Mark Brown
2008-11-17 15:45 ` [PATCH] leds: Handle maximum current setting over maximum supported for WM8350 Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2008-11-26 18:26 [PATCH] leds: Add WM8350 LED driver Mark Brown
2008-11-26 13:53 Mark Brown
2008-11-26 17:39 ` Sven Wegener
2008-11-26 18:17 ` Mark Brown
2008-11-13 12:39 Mark Brown
2008-11-14 23:19 ` Andrew Morton
2008-11-17 11:57 ` Mark Brown
2008-11-15 17:29 ` Pavel Machek
2008-11-15 17:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117152506.GA29949@gambetta \
--to=frederik.deweerdt@xprog.eu \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox