From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Roland McGrath <roland@redhat.com>,
Doug Chapman <doug.chapman@hp.com>,
Frank Mayhar <fmayhar@google.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/3] thread_group_cputime: move a couple of callsites outside of ->siglock
Date: Mon, 17 Nov 2008 16:57:06 +0100 [thread overview]
Message-ID: <20081117155706.GC12081@elte.hu> (raw)
In-Reply-To: <20081117144008.GA5386@redhat.com>
* Oleg Nesterov <oleg@redhat.com> wrote:
> ->siglock buys nothing for thread_group_cputime() in do_sys_times() and
> wait_task_zombie() (which btw takes the unrelated parent's ->siglock).
> Actually I think do_sys_times() doesn't need ->siglock at all.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
applied your changes to tip/core/signal:
2b5fe6d: thread_group_cputime: move a couple of callsites outside of ->siglock
ce39447: thread_group_cputime: kill the bogus ->signal != NULL check
74fcd52: account_steal_time: kill the unneeded account_group_system_time()
(merged the sched/urgent fixlet before them)
thanks Oleg!
Ingo
prev parent reply other threads:[~2008-11-17 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 14:40 [PATCH 4/3] thread_group_cputime: move a couple of callsites outside of ->siglock Oleg Nesterov
2008-11-17 15:57 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117155706.GC12081@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=doug.chapman@hp.com \
--cc=fmayhar@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox