Re: [Tpctl-users] Inclusion of tp_smapi module into kernel?

Pavel Machek
2008-11-23T17:26:59Z

On Mon 2008-11-17 15:27:04, Theodore Tso wrote:
> On Mon, Nov 17, 2008 at 11:21:09AM -0800, H. Peter Anvin wrote:
> >> We've discussed that in private at the time, and recently on LKML too.
> >> In summary:
> >> I'm fine with that, and so is everybody I talked to (including Linus),
> >> except Greg KH who vetoed it since he believes the code is irrevocably
> >> and contagiously evil.
> >>
> >
> > Signed-off-by is about copyright, it's not a review issue. It means "I
> > certify that I know that the author had the rights to submit this code."
> > Code quality is important but separate.
>
> Indeed; so what were Greg KH's complaints, specifically? Were they a
> code review issue or was just complaining about the anonymity issue?

Anonymity issue.

I'm working on similar driver for HP machines, and it would be great
to be able to test that on my thinkpad, so I'm willing to clean up
the code if required, maintain it, whatever...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html