Re: [Tpctl-users] Inclusion of tp_smapi module into kernel?

Henrique de Moraes Holschuh
2008-11-18T13:49:21Z

On Mon, 17 Nov 2008, Miklos Szeredi wrote:
> On Mon, 17 Nov 2008, H. Peter Anvin wrote:
> > Shem Multinymous wrote:
> > > On Mon, Nov 17, 2008 at 12:13 PM, J.R. Mauro <jrm8005@gmail.com> wrote:
> > >> There are several utilities maintained by this author, and finding
> > >> some way to merge the code has been tried more than once. If you look
> > >> back far enough, Andrew asked to have another of the project's members
> > >> sign off on the patch, and maybe that would be acceptable enough, but
> > >> afaik the author has never responded directly to that idea.
> > >
> > > We've discussed that in private at the time, and recently on LKML too.
> > > In summary:
> > > I'm fine with that, and so is everybody I talked to (including Linus),
> > > except Greg KH who vetoed it since he believes the code is irrevocably
> > > and contagiously evil.
> > >
> >
> > Signed-off-by is about copyright, it's not a review issue. It means "I
> > certify that I know that the author had the rights to submit this code."
> > Code quality is important but separate.
>
> We've discussed this issue on the internal suse mailing lists, and
> concluded that the solution is simple: someone from IBM, Lenovo or
> whoever they license the technology from should sign off on the code.

That would be nice, yes.

> But implementing this got stuck at some stage.
>
> Can anybody help with info about who's responsible for this part of
> the ThinkPad?

SuSE has direct management-level and engineering-level contacts with the
Lenovo team responsible for the ThinkPad. IMO, the contact needs to be done
through those channels (which are Linux-friendly).

If SuSE decided not to do it, they must have had their reasons. I wouldn't
know them, but I can guess as much as anyone else, and my pet guess is that
they are waiting for an opportune time.

If you work with SuSE, you could try to use your internal channels to find
out what really is happening.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh