From: Ingo Molnar <mingo@elte.hu>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kernel/profile.c: Fix section mismatch warning.
Date: Tue, 18 Nov 2008 08:48:52 +0100 [thread overview]
Message-ID: <20081118074850.GC17838@elte.hu> (raw)
In-Reply-To: <b9df5fa10811172015w3dfb955bq115180d9d0808d82@mail.gmail.com>
* Rakib Mullick <rakib.mullick@gmail.com> wrote:
> Impact: Fix section mismatch warning in kernel/profile.c
>
> Here, profile_nop function has been called from a non-init function
> create_hash_tables(void). Which generetes a section mismatch warning.
> Previously, create_hash_tables(void) was a init function. So, removing
> __init from create_hash_tables(void) requires profile_nop to be
> non-init. This patch makes profile_nop function inline and fixes the
> following warning:
>
> WARNING: vmlinux.o(.text+0x6ebb6): Section mismatch in reference from
> the function create_hash_tables() to the function
> .init.text:profile_nop()
> The function create_hash_tables() references
> the function __init profile_nop().
> This is often because create_hash_tables lacks a __init
> annotation or the annotation of profile_nop is wrong.
>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
>
> --- linux-2.6-orig/kernel/profile.c 2008-11-17 20:30:42.000000000 +0600
> +++ linux-2.6/kernel/profile.c 2008-11-18 09:39:58.000000000 +0600
> @@ -544,7 +544,7 @@ static const struct file_operations proc
> };
>
> #ifdef CONFIG_SMP
> -static void __init profile_nop(void *unused)
> +static inline void profile_nop(void *unused)
> {
> }
applied to tip/core/urgent, thanks!
Ingo
next prev parent reply other threads:[~2008-11-18 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 4:15 [PATCH] kernel/profile.c: Fix section mismatch warning Rakib Mullick
2008-11-18 7:48 ` Ingo Molnar [this message]
2008-11-19 6:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118074850.GC17838@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox