From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbYKRIOW (ORCPT ); Tue, 18 Nov 2008 03:14:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750950AbYKRIOO (ORCPT ); Tue, 18 Nov 2008 03:14:14 -0500 Received: from miranda.se.axis.com ([193.13.178.8]:36923 "EHLO miranda.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbYKRION (ORCPT ); Tue, 18 Nov 2008 03:14:13 -0500 Date: Tue, 18 Nov 2008 09:14:07 +0100 From: Jesper Nilsson To: Greg KH Cc: Kay Sievers , linux-kernel Subject: Re: chris: struct device - replace bus_id with dev_name(), dev_set_name() Message-ID: <20081118081407.GA4856@axis.com> References: <1226018320.3189.9.camel@nga> <20081107120136.GD4013@axis.com> <20081117225359.GB10377@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081117225359.GB10377@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 17, 2008 at 11:53:59PM +0100, Greg KH wrote: > On Fri, Nov 07, 2008 at 01:01:36PM +0100, Jesper Nilsson wrote: > > On Fri, Nov 07, 2008 at 01:38:40AM +0100, Kay Sievers wrote: > > > This patch is part of a larger patch series which will remove > > > the "char bus_id[20]" name string from struct device. The device > > > name is managed in the kobject anyway, and without any size > > > limitation, and just needlessly copied into "struct device". > > > > Thanks, but I think that since this driver has been broken a long time > > it is high time to fix it, and I think the fix removes the need for your patch. > > > > Greg, could you please look this patch over? > > > > > > [CRISv32] Fix IOP fw-loader to use platform_device. > > > > Change IOP fw-loader to use platform_device instead of > > raw device, which should be more correct usage. > > > > Signed-off-by: Stefan Andersson > > Signed-off-by: Jesper Nilsson > > Looks sane to me. Want me to take it through my tree, or will you be > submitting it? Thanks, good to hear, I'll take it into the CRIS-tree. > thanks, > > greg k-h /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com