From: Christoph Hellwig <hch@lst.de>
To: mtk.manpages@gmail.com
Cc: Evgeniy Polyakov <zbr@ioremap.net>, Robert Love <rlove@rlove.org>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [take 3] Use pid in inotify events.
Date: Tue, 18 Nov 2008 14:19:37 +0100 [thread overview]
Message-ID: <20081118131937.GC16944@lst.de> (raw)
In-Reply-To: <cfd18e0f0811170859w1d3f903ej1d5626f2d2bf4496@mail.gmail.com>
On Mon, Nov 17, 2008 at 11:59:11AM -0500, Michael Kerrisk wrote:
> NAK. If we are going to do this -- and I leave the security
> discussions to others more knowlegeable on that score than me -- then
> the API design should be better than this. The current design is a
> hack. Why exclude rename events? Why re-use the cookie field? The
> only answers I can guess at are that the current patch is less work to
> write. IMO, there are (much) better design possibilities, using
> inotify1(), as I suggested earlier in this thread.
Yes, this kind of thing should be enable using an flag to inotify1, and
be consistant even for rename. Doing it as a flag to inotify1 also has
the advantage to be able to return an -EPERM when the feature is
requested but not allowed instead of letting applications that assume it
silently fail.
next prev parent reply other threads:[~2008-11-18 13:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <acdcfe7e0811081035l56eedf05x8b3b7ee2fc01eee6@mail.gmail.com>
2008-11-08 18:40 ` [1/1] Use pid in inotify events Evgeniy Polyakov
2008-11-08 22:03 ` Evgeniy Polyakov
2008-11-10 15:13 ` [take 2] " Evgeniy Polyakov
2008-11-16 23:24 ` [take 3] " Evgeniy Polyakov
2008-11-17 16:59 ` Michael Kerrisk
2008-11-17 17:15 ` Evgeniy Polyakov
2008-11-17 17:23 ` Michael Kerrisk
2008-11-17 17:52 ` Evgeniy Polyakov
2008-11-20 13:09 ` Pavel Machek
2008-11-21 14:03 ` Evgeniy Polyakov
2008-11-21 14:20 ` Michael Kerrisk
2008-11-21 14:37 ` Evgeniy Polyakov
2008-11-21 14:30 ` Robert Love
2008-11-21 14:53 ` Evgeniy Polyakov
2008-11-21 14:57 ` Pavel Machek
2008-11-21 15:08 ` Evgeniy Polyakov
2008-11-18 13:19 ` Christoph Hellwig [this message]
2008-11-19 14:05 ` Evgeniy Polyakov
[not found] ` <cfd18e0f0811190634g276b4a2dm5b3d5de25a5c9222@mail.gmail.com>
2008-11-19 14:43 ` Michael Kerrisk
2008-11-20 19:17 ` Ville Syrjälä
2008-11-19 14:53 ` Evgeniy Polyakov
2008-11-20 22:34 ` John McCutchan
2008-11-20 23:06 ` Evgeniy Polyakov
2008-11-21 18:39 ` Arnd Bergmann
2008-11-22 7:12 ` David Newall
2008-11-22 9:41 ` Evgeniy Polyakov
2008-11-22 11:41 ` David Newall
2008-11-22 9:37 ` Evgeniy Polyakov
2008-11-24 5:08 ` John McCutchan
2008-11-24 7:30 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118131937.GC16944@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=rlove@rlove.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox