From: Ingo Molnar <mingo@elte.hu>
To: Philipp Kohlbecher <xt28@gmx.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: more general identifier for Phoenix BIOS
Date: Tue, 18 Nov 2008 16:12:22 +0100 [thread overview]
Message-ID: <20081118151222.GG30358@elte.hu> (raw)
In-Reply-To: <491FFFC5.9080006@gmx.de>
* Philipp Kohlbecher <xt28@gmx.de> wrote:
> Phoenix BIOSes variously identify their vendor as "Phoenix Technologies,
> LTD" or "Phoenix Technologies LTD" (without the comma.)
>
> This patch makes the identification string in the bad_bios_dmi_table
> more general (following a suggestion by Ingo Molnar), so that both
> versions are handled.
>
> Again, the patched file compiles cleanly and the patch has been tested
> successfully on my machine.
>
> Signed-off-by: Philipp Kohlbecher <xt28@gmx.de>
applied to tip/x86/urgent, thanks Philipp!
I also tagged it for -stable backporting.
>> Note that we should do a simpler patch: just change the string to
>> "Phoenix Technologies" and that will provide a proper match. (DMI
>> matches work on substrings too)
>
> Done. (I wasn't sure whether you were saying that *I* should write
> this simpler patch or that you would. Anyway, here it is.)
yeah, developers/users writing patches is always the preferred
solution! It's the vector that spreads Linux development to new areas
and new people.
Ingo
next prev parent reply other threads:[~2008-11-18 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 15:42 [PATCH] x86: alternative identifier for Phoenix BIOS Philipp Kohlbecher
2008-11-16 1:55 ` H. Peter Anvin
2008-11-16 7:23 ` Ingo Molnar
2008-11-16 11:11 ` [PATCH v2] x86: more general " Philipp Kohlbecher
2008-11-18 15:12 ` Ingo Molnar [this message]
2008-11-16 11:14 ` [PATCH] x86: alternative " Alan Cox
2008-11-18 15:06 ` Ingo Molnar
2008-11-16 16:51 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118151222.GG30358@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=xt28@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox