From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Bryan Wu <cooloney@kernel.org>,
linux-kernel@vger.kernel.org,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH] asm/generic: fix bug - kernel fails to build when enable some common audit code on Blackfin
Date: Wed, 19 Nov 2008 07:08:06 +0000 [thread overview]
Message-ID: <20081119070806.GV28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20081118223308.396ec63b.akpm@linux-foundation.org>
On Tue, Nov 18, 2008 at 10:33:08PM -0800, Andrew Morton wrote:
> > @@ -1,6 +1,8 @@
> > #include <asm-generic/audit_dir_write.h>
> > __NR_acct,
> > +#ifdef __NR_swapon
> > __NR_swapon,
> > +#endif
> > __NR_quotactl,
> > __NR_truncate,
> > #ifdef __NR_truncate64
>
> hrm.
>
> Should blackfin define __NR_swapon instead? afacit
> include/asm/unistd.h is an exported-to-userspace header, so the
> architecture should export __NR_swapon to prevent userspace build
> failures?
Not in the absense of syscall in question. Patch applied, will push the
tree tomorrow.
next prev parent reply other threads:[~2008-11-19 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 7:03 [PATCH] asm/generic: fix bug - kernel fails to build when enable some common audit code on Blackfin Bryan Wu
2008-11-19 6:33 ` Andrew Morton
2008-11-19 7:08 ` Al Viro [this message]
2008-11-19 13:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119070806.GV28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox