From: Ingo Molnar <mingo@elte.hu>
To: Ken Chen <kenchen@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched: add locking when update the task_group's cfs_rq[] array.
Date: Wed, 19 Nov 2008 08:53:19 +0100 [thread overview]
Message-ID: <20081119075319.GA1078@elte.hu> (raw)
In-Reply-To: <b040c32a0811182248s1174c82avf44c720ae2d14804@mail.gmail.com>
* Ken Chen <kenchen@google.com> wrote:
> @@ -1513,8 +1513,12 @@ static int tg_shares_up
> unsigned long weight, rq_weight = 0;
> unsigned long shares = 0;
> struct sched_domain *sd = data;
> + unsigned long flags;
> int i;
>
> + if (!spin_trylock_irqsave(&tg->tg_lock, flags))
> + return 0;
hm, why trylock?
Ingo
next prev parent reply other threads:[~2008-11-19 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 6:48 [patch] sched: add locking when update the task_group's cfs_rq[] array Ken Chen
2008-11-19 7:53 ` Ingo Molnar [this message]
2008-11-19 8:22 ` Ken Chen
2008-11-19 16:54 ` Peter Zijlstra
2008-11-19 17:21 ` Ken Chen
2008-11-19 20:58 ` Peter Zijlstra
2008-11-19 21:50 ` Chris Friesen
2008-11-22 10:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119075319.GA1078@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox