Re: [PATCH] udf: implement mode and dmode mounting options

Jan Kara
2008-11-19T15:16:18Z

On Tue 18-11-08 16:22:05, Andrew Morton wrote:
> On Sun, 16 Nov 2008 20:52:19 +0100
> Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
>
> > "dmode" allows overriding permissions of directories and
> > "mode" allows overriding permissions of files.
> >
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > Cc: Jan Kara <jack@suse.cz>
> > ---
> > Documentation/filesystems/udf.txt | 2 ++
> > fs/udf/inode.c | 11 +++++++++--
> > fs/udf/super.c | 31 ++++++++++++++++++++++++++++++-
> > fs/udf/udf_sb.h | 2 ++
> > 4 files changed, 43 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/filesystems/udf.txt b/Documentation/filesystems/udf.txt
> > index fde829a..902b95d 100644
> > --- a/Documentation/filesystems/udf.txt
> > +++ b/Documentation/filesystems/udf.txt
> > @@ -24,6 +24,8 @@ The following mount options are supported:
> >
> > gid= Set the default group.
> > umask= Set the default umask.
> > + mode= Set the default file permissions.
> > + dmode= Set the default directory permissions.
>
> Can we give these the same names and usage as their fatfs equivalents?
Yes, making these options dmask and fmask would be more consistent I
think. Martin?

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR