Re: [PATCH] udf: implement mode and dmode mounting options

Marcin Slusarz
2008-11-19T18:15:39Z

On Wed, Nov 19, 2008 at 04:16:06PM +0100, Jan Kara wrote:
> On Tue 18-11-08 16:22:05, Andrew Morton wrote:
> > On Sun, 16 Nov 2008 20:52:19 +0100
> > Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> >
> > > "dmode" allows overriding permissions of directories and
> > > "mode" allows overriding permissions of files.
> > >
> > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > > Cc: Jan Kara <jack@suse.cz>
> > > ---
> > > Documentation/filesystems/udf.txt | 2 ++
> > > fs/udf/inode.c | 11 +++++++++--
> > > fs/udf/super.c | 31 ++++++++++++++++++++++++++++++-
> > > fs/udf/udf_sb.h | 2 ++
> > > 4 files changed, 43 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/filesystems/udf.txt b/Documentation/filesystems/udf.txt
> > > index fde829a..902b95d 100644
> > > --- a/Documentation/filesystems/udf.txt
> > > +++ b/Documentation/filesystems/udf.txt
> > > @@ -24,6 +24,8 @@ The following mount options are supported:
> > >
> > > gid= Set the default group.
> > > umask= Set the default umask.
> > > + mode= Set the default file permissions.
> > > + dmode= Set the default directory permissions.
> >
> > Can we give these the same names and usage as their fatfs equivalents?
> Yes, making these options dmask and fmask would be more consistent I
> think. Martin?

You can't add permissions by umask/fmask/dmask. I have one DVD with top
level dir permissions set to 0000 and there's no way to read it now (as
an user) and adding mask options wouldn't change it.

I should mention in a changelog that the names and semantics of these
options are copied from isofs.

I can create a second patch which adds mask options but I think modes are
needed too. What do you think?

Marcin