From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
ink@jurassic.park.msu.ru, starvik@axis.com, tony.luck@intel.com,
takata@linux-m32r.org, ralf@linux-mips.org,
grundler@parisc-linux.org, paulus@samba.org,
schwidefsky@de.ibm.com, lethal@linux-sh.org, wli@holomorphy.com,
davem@davemloft.net, jdike@addtoit.com, mingo@redhat.com
Subject: Re: [PATCH 1/2] cpumask: centralize cpu_online_map and cpu_possible_map
Date: Wed, 19 Nov 2008 18:17:44 +0000 [thread overview]
Message-ID: <20081119181743.GA31357@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200811200107.18162.rusty@rustcorp.com.au>
On Thu, Nov 20, 2008 at 01:07:16AM +1030, Rusty Russell wrote:
> diff -r c8ab7f6fc5e8 kernel/cpu.c
> --- a/kernel/cpu.c Fri Oct 31 10:48:30 2008 +1100
> +++ b/kernel/cpu.c Fri Oct 31 11:22:29 2008 +1100
> @@ -24,19 +24,20 @@ cpumask_t cpu_present_map __read_mostly;
> cpumask_t cpu_present_map __read_mostly;
> EXPORT_SYMBOL(cpu_present_map);
>
> -#ifndef CONFIG_SMP
> -
> /*
> * Represents all cpu's that are currently online.
> */
> -cpumask_t cpu_online_map __read_mostly = CPU_MASK_ALL;
> +cpumask_t cpu_online_map __read_mostly;
Just a question: in the uniprocessor case, does this mean that
cpu_online_map becomes zero or do we mark cpu0 as online somewhere?
I couldn't see it in this patch.
I'm just wondering from a review point of view whether this change
of initialization could have undesirable side effects.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-11-19 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 14:37 [PATCH 1/2] cpumask: centralize cpu_online_map and cpu_possible_map Rusty Russell
2008-11-19 18:17 ` Russell King [this message]
2008-11-19 23:30 ` Rusty Russell
2008-11-20 5:10 ` Grant Grundler
2008-11-20 8:20 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119181743.GA31357@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jdike@addtoit.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tony.luck@intel.com \
--cc=travis@sgi.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox