From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>
Subject: Re: [PATCH] sched: Don't allow priority switch to realtime when the task doesn't belong to init_task_group and when CONFIG_RT_GROUP_SCHED isn't set
Date: Thu, 20 Nov 2008 13:49:24 +0530 [thread overview]
Message-ID: <20081120081924.GB4349@in.ibm.com> (raw)
In-Reply-To: <20081120075829.GA21785@elte.hu>
On Thu, Nov 20, 2008 at 08:58:29AM +0100, Ingo Molnar wrote:
> <snip>
> hm, another option would be, instead of denying something (which
> denial might not even be noticed by the app) that the app clearly has
> enough privilege to request - to just act upon it and move the task to
> the init_task_group?
Thought about that option, but decided against it because:
- The task was started in a group which is not "equipped" to handle
rt tasks (no rt_rq for the group because CONFIG_RT_GROUP_SCHED=n). So
the task shouldn't have been started in such a group in the first
place.
- We could move the task silently to init_task_group (which is kind
of done now with the task being placed in init_task_group's rq), but
that's not what a user would have expected when he started a task
under a group.
Also, silently moving the task to init_task_group would cause confusion
later when the task drops the RT privilege. As Dhaval is asking in the
other thread, which group do we move it to now ?
Regards,
Bharata.
next prev parent reply other threads:[~2008-11-20 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 6:18 [PATCH] sched: Don't allow priority switch to realtime when the task doesn't belong to init_task_group and when CONFIG_RT_GROUP_SCHED isn't set Bharata B Rao
2008-11-20 7:58 ` Ingo Molnar
2008-11-20 8:03 ` Dhaval Giani
2008-11-20 8:17 ` Ingo Molnar
2008-11-20 8:19 ` Bharata B Rao [this message]
2008-11-23 1:11 ` Peter Zijlstra
2008-11-24 3:58 ` Bharata B Rao
2008-11-24 8:32 ` Peter Zijlstra
2008-11-24 8:46 ` Dhaval Giani
2008-11-24 9:06 ` Peter Zijlstra
2008-11-24 15:24 ` Chris Friesen
2008-11-24 15:36 ` Peter Zijlstra
2008-11-25 18:51 ` Chris Friesen
2008-11-25 20:17 ` Peter Zijlstra
2008-11-24 17:05 ` Srivatsa Vaddagiri
2008-11-24 18:46 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120081924.GB4349@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox