Re: [PATCH 04/16] Blackfin SPI Driver: use len_in_bytes when we care about the number of bytes transferred

David Brownell
2008-11-20T20:52:05Z

On Monday 17 November 2008, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@gmail.com>
>
> Use len_in_bytes when we care about the number of bytes transferred
> rather than the number of spi transactions. (this value will be the
> same for 8bit transfers, but not any other sizes)
>
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

> ---
> drivers/spi/spi_bfin5xx.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
> index 6c5671e..cc415e8 100644
> --- a/drivers/spi/spi_bfin5xx.c
> +++ b/drivers/spi/spi_bfin5xx.c
> @@ -803,7 +803,7 @@ static void pump_transfers(unsigned long data)
> if (bfin_addr_dcachable((unsigned long) drv_data->rx))
> invalidate_dcache_range((unsigned long) drv_data->rx,
> (unsigned long) (drv_data->rx +
> - drv_data->len));
> + drv_data->len_in_bytes));
>
> /* clear tx reg soformer data is not shifted out */
> write_TDBR(drv_data, 0xFFFF);
> @@ -829,7 +829,7 @@ static void pump_transfers(unsigned long data)
> if (bfin_addr_dcachable((unsigned long) drv_data->tx))
> flush_dcache_range((unsigned long) drv_data->tx,
> (unsigned long) (drv_data->tx +
> - drv_data->len));
> + drv_data->len_in_bytes));
>
> /* start dma */
> dma_enable_irq(drv_data->dma_channel);
> @@ -892,7 +892,7 @@ static void pump_transfers(unsigned long data)
> message->state = ERROR_STATE;
> } else {
> /* Update total byte transfered */
> - message->actual_length += drv_data->len;
> + message->actual_length += drv_data->len_in_bytes;
>
> /* Move to next transfer of this msg */
> message->state = next_transfer(drv_data);
> --
> 1.5.6.3
>
>