Re: [PATCH 10/16] Blackfin SPI Driver: use the properl BIT_CTL_xxx defines

David Brownell
2008-11-20T20:54:37Z

On Monday 17 November 2008, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@gmail.com>
>
> use the properl BIT_CTL_... defines rather than the internal driv
> er CFG_SPI_... defines
>

> @@ -821,12 +821,9 @@ static void pump_transfers(unsigned long data)
> (unsigned long) (drv_data->rx +
> drv_data->len_in_bytes));
>
> - /* clear tx reg soformer data is not shifted out */
> - write_TDBR(drv_data, 0xFFFF);
> -

This is unrelated to a BIT_CTL #define. It's a bug in
either the patch or its comment.

> dma_config |= WNR;
> dma_start_addr = (unsigned long)drv_data->rx;