From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mm: slab - __cache_alloc NULL prefetch fix
Date: Thu, 20 Nov 2008 21:24:37 +0300 [thread overview]
Message-ID: <20081120182437.GA22100@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0811201216110.23154@quilx.com>
[Christoph Lameter - Thu, Nov 20, 2008 at 12:16:28PM -0600]
| On Thu, 20 Nov 2008, Cyrill Gorcunov wrote:
|
| > even having prefetch(NULL) as valid we do check if
| > object is not NULL anyway so I thought there is no
| > need to prefetch(NULL) in case of fail.
|
| The object is only checked if SLAB_DEBUG is on.
|
My fault Christoph, I've been messed by kmemcheck_slab_alloc
which in turn actually becomes zero function if not tuned on.
So -- all is fine, sorry for noise.
- Cyrill -
next prev parent reply other threads:[~2008-11-20 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 16:44 mm: slab - __cache_alloc NULL prefetch fix Cyrill Gorcunov
2008-11-20 17:01 ` Cyrill Gorcunov
2008-11-20 18:16 ` Christoph Lameter
2008-11-20 18:24 ` Cyrill Gorcunov [this message]
2008-11-20 18:15 ` Christoph Lameter
2008-11-20 19:58 ` Valdis.Kletnieks
2008-11-20 20:03 ` Pekka Enberg
2008-11-20 20:10 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120182437.GA22100@localhost \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox